<div dir="ltr"><div>svn commit</div><div>Sending source/Symbol/FuncUnwinders.cpp</div><div>Transmitting file data .</div><div>Committed revision 216416.</div><div><br></div><div>Tested on Linux and MacOSX. All tests passed.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 25, 2014 at 4:11 PM, Tong Shen <span dir="ltr"><<a href="mailto:endlessroad@google.com" target="_blank">endlessroad@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Todd,<div><br></div><div>My patch alone. Confirmed.</div><div>Possible commit message: "Copy unwind plan instead of modifying it directly, so "image show-unwind" prints different plans for asynchronous and synchronous"</div>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 25, 2014 at 3:25 PM, Tong Shen <span dir="ltr"><<a href="mailto:endlessroad@google.com" target="_blank">endlessroad@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Got it :-)</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Aug 25, 2014 at 3:24 PM, Jason Molenda <span dir="ltr"><<a href="mailto:jmolenda@apple.com" target="_blank">jmolenda@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Awesome, thanks, I'll commit my patch. Please commit your patch to copy the UnwindPlan instead of modifying in place when you're ready.<br>
<div><div><br>
<br>
> On Aug 25, 2014, at 3:13 PM, Tong Shen <<a href="mailto:endlessroad@google.com" target="_blank">endlessroad@google.com</a>> wrote:<br>
><br>
> Hi Jason,<br>
><br>
> Patch confirmed, plan name changed as expected (and did not change for gcc because gcc describes epilogue as well).<br>
><br>
> I made a small change though: now that you brought up "image dump show-unwind", I found that I should make a copy of m_unwind_plan_call_site_sp instead of modifying it directly.<br>
> Now "image show-unwind" output looks like:<br>
><br>
> Asynchronous (not restricted to call-sites) UnwindPlan for 1`f (start addr 0x8048420):<br>
> This UnwindPlan originally sourced from eh_frame CFI plus augmentation from assembly parsing<br>
> Address range of this UnwindPlan: [1..text + 256-0x0000014b)<br>
> row[0]: 0x00000000: CFA=esp +4 => eip=[esp]<br>
> row[1]: 0x00000003: CFA=esp+24 => eip=[esp+20]<br>
> row[2]: 0x0000004a: CFA=esp +4 => eip=[esp]<br>
><br>
> Synchronous (restricted to call-sites) UnwindPlan for 1`f (start addr 0x8048420):<br>
> This UnwindPlan originally sourced from eh_frame CFI<br>
> Address range of this UnwindPlan: [1..text + 256-0x0000014b)<br>
> row[0]: 0x00000000: CFA=esp +4 => eip=[esp]<br>
> row[1]: 0x00000003: CFA=esp+24 => eip=[esp+20]<br>
><br>
> Architecture default UnwindPlan for 1`f (start addr 0x8048420):<br>
> This UnwindPlan originally sourced from i386 default unwind plan<br>
> row[0]: 0x00000000: CFA=ebp +8 => esp=ebp+8 ebp=[ebp] eip=[ebp+4]<br>
><br>
><br>
><br>
> On Mon, Aug 25, 2014 at 2:45 PM, Tong Shen <<a href="mailto:endlessroad@google.com" target="_blank">endlessroad@google.com</a>> wrote:<br>
> Of course :-)<br>
> Keeping the old name may cause confusion in the future.<br>
><br>
> I will test it now and make sure it works.<br>
><br>
> Thanks!<br>
><br>
><br>
> On Mon, Aug 25, 2014 at 2:43 PM, Jason Molenda <<a href="mailto:jmolenda@apple.com" target="_blank">jmolenda@apple.com</a>> wrote:<br>
> Hi Tong, I think it might be useful to note that the UnwindPlan has been modified (in case one of us is looking at it with "image dump show-unwind"). What do you think about this patch? I don't have eh_frame info on my system right now so I haven't tested this.<br>
><br>
><br>
><br>
><br>
> --<br>
> Best Regards, Tong Shen<br>
><br>
><br>
><br>
> --<br>
> Best Regards, Tong Shen<br>
</div></div>> <unwindplan-name_v2.txt><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Best Regards, Tong Shen</div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Best Regards, Tong Shen</div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>