<div dir="ltr">Awesome - fixes an issue in my branch as well :-)  Thanks, Jason!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 21, 2014 at 4:22 PM, Jason Molenda <span dir="ltr"><<a href="mailto:jmolenda@apple.com" target="_blank">jmolenda@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jmolenda<br>
Date: Thu Aug 21 18:22:33 2014<br>
New Revision: 216243<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216243&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=216243&view=rev</a><br>
Log:<br>
Two small fixes to get Mac native + debugserver working after the<br>
HostInfo et al changes from Zachary.  Changes suggested by Zachary<br>
- fixes the problems I was seeing.<br>
<br>
<br>
Modified:<br>
    lldb/trunk/source/Host/macosx/Host.mm<br>
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
<br>
Modified: lldb/trunk/source/Host/macosx/Host.mm<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/Host.mm?rev=216243&r1=216242&r2=216243&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/Host.mm?rev=216243&r1=216242&r2=216243&view=diff</a><br>

==============================================================================<br>
--- lldb/trunk/source/Host/macosx/Host.mm (original)<br>
+++ lldb/trunk/source/Host/macosx/Host.mm Thu Aug 21 18:22:33 2014<br>
@@ -1255,7 +1255,7 @@ LaunchProcessXPC (const char *exe_path,<br>
     const char *xpc_service  = nil;<br>
     bool send_auth = false;<br>
     AuthorizationExternalForm extForm;<br>
-    if ((requested_uid == UINT32_MAX) || (requested_uid == Host::GetEffectiveUserID()))<br>
+    if ((requested_uid == UINT32_MAX) || (requested_uid == HostInfo::GetEffectiveUserID()))<br>
     {<br>
         xpc_service = "com.apple.lldb.launcherXPCService";<br>
     }<br>
@@ -1392,7 +1392,7 @@ ShouldLaunchUsingXPC(ProcessLaunchInfo &<br>
<br>
 #if !NO_XPC_SERVICES<br>
     bool launchingAsRoot = launch_info.GetUserID() == 0;<br>
-    bool currentUserIsRoot = Host::GetEffectiveUserID() == 0;<br>
+    bool currentUserIsRoot = HostInfo::GetEffectiveUserID() == 0;<br>
<br>
     if (launchingAsRoot && !currentUserIsRoot)<br>
     {<br>
<br>
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp?rev=216243&r1=216242&r2=216243&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp?rev=216243&r1=216242&r2=216243&view=diff</a><br>

==============================================================================<br>
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp (original)<br>
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Thu Aug 21 18:22:33 2014<br>
@@ -687,7 +687,7 @@ GDBRemoteCommunication::StartDebugserver<br>
         // directory.<br>
         if (HostInfo::GetLLDBPath(ePathTypeSupportExecutableDir, debugserver_file_spec))<br>
         {<br>
-            debugserver_file_spec.GetFilename().SetCString(DEBUGSERVER_BASENAME);<br>
+            debugserver_file_spec.AppendPathComponent (DEBUGSERVER_BASENAME);<br>
             debugserver_exists = debugserver_file_spec.Exists();<br>
             if (debugserver_exists)<br>
             {<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">-Todd</div>
</div>