<div dir="ltr">Since this involves moving quite a bit of code around, I want to make sure it's formatted correctly.  I know LLVM has an 80-column limit, but LLDB doesn't seem to adhere to the same limit.  Or at least if it does, it's not consistent.  Do you have a preference here?   BTW, it would be nice if <a href="http://lldb.llvm.org/">http://lldb.llvm.org/</a> outlined the ways in which the coding style for LLDB differed from the coding style for LLVM.  Some rules are obvious, such as 4-space indentation, but others are not so obvious.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 18, 2014 at 4:27 PM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I like the using of the C++11 <thread> for some stuff as we may be able to use more of the C++11 standard library as the host layer for common base classes.<br>
<br>
Looks good.<br>
<div><div class="h5"><br>
<br>
> On Aug 18, 2014, at 4:05 PM, Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br>
><br>
> This change implements the beginning of the HostInfo class - a class whose purpose is to answer queries about the host operating system.<br>
><br>
> This compiles successfully and passes all tests on Linux, MacOSX, and Windows.  I do not have access to a FreeBSD build machine, so would appreciate help there.<br>
><br>
> <a href="http://reviews.llvm.org/D4963" target="_blank">http://reviews.llvm.org/D4963</a><br>
><br>
> Files:<br>
>  include/lldb/Core/ArchSpec.h<br>
>  include/lldb/Host/Host.h<br>
>  include/lldb/Host/HostInfo.h<br>
>  include/lldb/Host/HostInfoBase.h<br>
>  include/lldb/Host/freebsd/HostInfoFreeBSD.h<br>
>  include/lldb/Host/linux/HostInfoLinux.h<br>
>  include/lldb/Host/macosx/HostInfoMacOSX.h<br>
>  include/lldb/Host/posix/HostInfoPosix.h<br>
>  include/lldb/Host/windows/HostInfoWindows.h<br>
>  include/lldb/Target/Platform.h<br>
>  lldb.xcodeproj/project.pbxproj<br>
>  source/Core/DataBufferMemoryMap.cpp<br>
>  source/Expression/ClangUserExpression.cpp<br>
>  source/Host/CMakeLists.txt<br>
>  source/Host/common/Host.cpp<br>
>  source/Host/common/HostInfoBase.cpp<br>
>  source/Host/freebsd/Host.cpp<br>
>  source/Host/freebsd/HostInfoFreeBSD.cpp<br>
>  source/Host/linux/Host.cpp<br>
>  source/Host/linux/HostInfoLinux.cpp<br>
>  source/Host/macosx/Host.mm<br>
>  source/Host/macosx/HostInfoMacOSX.mm<br>
>  source/Host/posix/HostInfoPosix.cpp<br>
>  source/Host/windows/Host.cpp<br>
>  source/Host/windows/HostInfoWindows.cpp<br>
>  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp<br>
>  source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp<br>
>  source/Plugins/Platform/Windows/PlatformWindows.cpp<br>
>  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp<br>
>  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp<br>
>  source/Target/Platform.cpp<br>
>  source/Target/ThreadPlanCallUserExpression.cpp<br>
</div></div>> <D4963.12633.patch>_______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br>
</blockquote></div><br></div>