<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Ah, well, my bad then - I didn’t realize I had never filled in that function!</div><div class=""><br class=""></div><div class="">It would be nice to get a more detailed look at what the issue is, definitely - I am somewhat busy these days so I won’t get a chance to figure this one out for a while; if you’re in the zone enough that you want to pursue this deeper, be my guest :)</div><div class="">If not, I would say, let’s just make a function</div><div class=""><br class=""></div><div class="">def exitTestSuite(exitCode = None):</div><div class=""> lldb.SBDebugger.Terminate()</div><div class=""> if exitCode: sys.exit(exitCode)</div><div class=""><br class=""></div><div class="">and then always call exitTestSuite() instead of duplicating the Terminate() and exit() calls in several places (if we want to do a third thing on exit, then we know we only have one place to edit instead of several)</div><div class=""><br class=""></div><div class="">Once that is addressed, LGTM and you should feel free to commit</div><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 8, 2014, at 2:59 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I just didn't revert the changes to dotest.py. I do agree that it would be nice to figure out what, if any problem there is with atexit(), but TBH my python (and even moreso my embedded python) is not the strongest, so I'm kind of handicapped in that regard, and I also think it just makes for easier debugging and easier to rationalize about the code-flow without them. Regarding your original comment about the proposed patch removing the cleanup for the crashinfo.so, that atexit handler was actually not even doing anything (empty function).<div class="">
<br class=""></div><div class="">Let me know if you want me to look into this more though. </div></div><div class="gmail_extra"><br class=""><br class=""><div class="gmail_quote">On Fri, Aug 8, 2014 at 1:23 PM, Enrico Granata <span dir="ltr" class=""><<a href="mailto:egranata@apple.com" target="_blank" class="">egranata@apple.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">Do we still get crashes because of the usage of atexit(), or did you simply not revert the changes to dotest.py?</div>
<div class=""><br class=""></div><div class="">With the exception of those, the rest of your patch LGTM</div><br class=""><div class=""><blockquote type="cite" class=""><div class=""><div class="h5"><div class="">On Aug 8, 2014, at 11:19 AM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank" class="">zturner@google.com</a>> wrote:</div>
<br class=""></div></div><div class=""><div class=""><div class="h5">Got rid of the Release() method and wrapped the destructor-based decrefs inside of Py_IsInitialized() checks.<br class=""><br class=""><a href="http://reviews.llvm.org/D4826" target="_blank" class="">http://reviews.llvm.org/D4826</a><br class="">
<br class="">Files:<br class=""> include/lldb/Interpreter/PythonDataObjects.h<br class=""> include/lldb/Interpreter/ScriptInterpreterPython.h<br class=""> source/Interpreter/ScriptInterpreterPython.cpp<br class=""> test/dotest.py<br class=""></div></div><span class=""><D4826.12310.patch></span>_______________________________________________<div class="">
<br class="">lldb-commits mailing list<br class=""><a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank" class="">lldb-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br class="">
</div></div></blockquote></div><div class=""><br class=""><div class="">
<div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class="">
<div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div style="letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class="">
<div class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div><div class=""><br class=""></div></div></div></div></div><br class="">
</div>
<br class=""></div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div><div class=""><br class=""></div></div></div></div></div><br class="Apple-interchange-newline">
</div>
<br class=""></body></html>