<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Do we still get crashes because of the usage of atexit(), or did you simply not revert the changes to dotest.py?</div><div class=""><br class=""></div><div class="">With the exception of those, the rest of your patch LGTM</div><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 8, 2014, at 11:19 AM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Got rid of the Release() method and wrapped the destructor-based decrefs inside of Py_IsInitialized() checks.<br class=""><br class=""><a href="http://reviews.llvm.org/D4826" class="">http://reviews.llvm.org/D4826</a><br class=""><br class="">Files:<br class=""> include/lldb/Interpreter/PythonDataObjects.h<br class=""> include/lldb/Interpreter/ScriptInterpreterPython.h<br class=""> source/Interpreter/ScriptInterpreterPython.cpp<br class=""> test/dotest.py<br class=""><span id="cid:192F4886-5130-4F5B-92F3-811F4DEF4591@apple.com"><D4826.12310.patch></span>_______________________________________________<br class="">lldb-commits mailing list<br class="">lldb-commits@cs.uiuc.edu<br class="">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits<br class=""></div></blockquote></div><br class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div><div class=""><br class=""></div></div></div></div></div><br class="Apple-interchange-newline">
</div>
<br class=""></body></html>