<div dir="ltr">I don't know much about the ARM / cpu subtype change, but the socket change is good, thanks for fixing that.  Please submit the socket fix separately from the other one though.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Aug 6, 2014 at 2:06 PM, Keno Fischer <span dir="ltr"><<a href="mailto:kfischer@college.harvard.edu" target="_blank">kfischer@college.harvard.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi zturner,<br>
<br>
Two changes:<br>
 - The first is a new constant introduced in XCode 6, so we do the same thing as for CPU_SUBTYPE_X86_64_H<br>
 - The second is small fix to the commit adding Host/Socket to make it build on OS X<br>
<br>
<a href="http://reviews.llvm.org/D4815" target="_blank">http://reviews.llvm.org/D4815</a><br>
<br>
Files:<br>
  source/Host/common/Host.cpp<br>
  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
<br>
Index: source/Host/common/Host.cpp<br>
===================================================================<br>
--- source/Host/common/Host.cpp<br>
+++ source/Host/common/Host.cpp<br>
@@ -40,6 +40,9 @@<br>
 #ifndef CPU_SUBTYPE_X86_64_H<br>
 #define CPU_SUBTYPE_X86_64_H ((cpu_subtype_t)8)<br>
 #endif<br>
+#ifndef CPU_TYPE_ARM64<br>
+#define CPU_TYPE_ARM64 (CPU_TYPE_ARM|CPU_ARCH_ABI64)<br>
+#endif<br>
 #endif<br>
<br>
 #if defined (__linux__) || defined (__FreeBSD__) || defined (__FreeBSD_kernel__) || defined (__APPLE__) || defined(__NetBSD__)<br>
Index: source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
===================================================================<br>
--- source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
+++ source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
@@ -22,6 +22,7 @@<br>
 #include "lldb/Core/UUID.h"<br>
 #include "lldb/Host/Host.h"<br>
 #include "lldb/Host/Symbols.h"<br>
+#include "lldb/Host/Socket.h"<br>
 #include "lldb/Interpreter/CommandInterpreter.h"<br>
 #include "lldb/Interpreter/CommandObject.h"<br>
 #include "lldb/Interpreter/CommandObjectMultiword.h"<br>
@@ -272,8 +273,8 @@<br>
<br>
     if (conn_ap->IsConnected())<br>
     {<br>
-        const Socket& socket = static_cast<const Socket&>(conn_ap->GetReadObject());<br>
-        const uint16_t reply_port = socket.GetPort();<br>
+        const Socket& socket = static_cast<const Socket&>(*conn_ap->GetReadObject());<br>
+        const uint16_t reply_port = socket.GetPortNumber();<br>
<br>
         if (reply_port != 0)<br>
         {<br>
</blockquote></div><br></div>