<div dir="ltr">Okay, sounds good Matthew. I'll have a look at the review you put out sometime today.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 29, 2014 at 2:22 AM, Matthew Gardiner <span dir="ltr"><<a href="mailto:mg11@csr.com" target="_blank">mg11@csr.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Guys,<br>
<br>
I'm going to limit the scope of my current work to just fixing the triple (i.e. change it to plaintext string encoding, and the revert documentation). I'm unclear of the intended encoding of the other items we'd mentioned. I'll come back to them later.<br>
<br>
Matt<br>
<br>
Todd Fiala wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<br>
<br>
<br>
On Mon, Jul 28, 2014 at 2:25 AM, Matthew Gardiner <<a href="mailto:mg11@csr.com" target="_blank">mg11@csr.com</a> <mailto:<a href="mailto:mg11@csr.com" target="_blank">mg11@csr.com</a>>> wrote:<br>
<br>
Todd/Jason,<br>
<br>
I'm happy to do this work, i.e. changes to<br>
GDBRemoteCommunicationServer.<u></u>cpp and<br>
GDBRemoteCommunicationClient.<u></u>cpp. (And to change the kalimba stub<br>
is easy). As I have just acquired commit access to lldb this could<br>
be a useful piece of work to introduce me to the Phabricator<br>
review process.<br>
<br>
<br>
Great, have at it!<br>
<br>
A couple of questions remain, though.<br>
<br>
Todd's comment:<br>
<br>
<br>
"Are there any ramifications for<br>
your usage of lldb-platform, though? We’d need to change the<br>
receiver code<br>
of that, which would then differ based on which lldb-platform version<br>
you’re talking to."<br>
<br>
<br>
Is that meaning that there are installed lldb-platform binaries<br>
which will now be broken against a version of lldb which expects<br>
plain text triples? Is that a problem? (that is, __will__ people<br>
upgrade both lldb and lldb-platform separately).<br>
<br>
<br>
Matthew, this was my misunderstanding. I had thought lldb-platform shipped with all the Apple platforms. They fixed my understanding - it only gets downloaded to devices as needed but doesn't live there. So this is a non-issue. As for llgs using it, that should not be an issue as llgs is just getting functional now and backwards support isn't a concern just yet.<br>
<br>
Todd, do you know if distribution_id, os_build, os_kernel need to<br>
converted to plain-text?<br>
<br>
<br>
I added distribution_id to indicate the Linux distribution, since it looks like on Android that might be the only way I can tell Android and its Androidisms apart from a stock Linux. On Linux, it grabs the content from the lsb_release exe, which really could be anything. If we wanted to switch that to binary encoding, that should be fine. You could change that one.<br>
<br>
Somebody else should probably comment on os_build/os_kernel.<br>
<br>
Jason, what is the problem with hostname? Previously you wrote<br>
that we are dealing with a user-specified string that may include<br>
non-alphanumeric characters. So in lldb/GDB-RSP context is a<br>
hostname different than that defined in<br>
<a href="http://tools.ietf.org/html/rfc952" target="_blank">http://tools.ietf.org/html/<u></u>rfc952</a>?<br>
<br>
Matt<br>
<br>
Todd Fiala wrote:<br>
<br>
Cool - sounds all good to me since we don't have a backwards<br>
compatibility problem. Now would be the time to do it :-)<br>
<br>
-Todd<br>
<br>
<br>
<br>
On Fri, Jul 25, 2014 at 12:40 PM, Jason Molenda<br>
<<a href="mailto:jason@molenda.com" target="_blank">jason@molenda.com</a> <mailto:<a href="mailto:jason@molenda.com" target="_blank">jason@molenda.com</a>><br></div></div><div class="">
<mailto:<a href="mailto:jason@molenda.com" target="_blank">jason@molenda.com</a> <mailto:<a href="mailto:jason@molenda.com" target="_blank">jason@molenda.com</a>>>> wrote:<br>
<br>
<br>
On Jul 25, 2014, at 7:08 AM, Todd Fiala <<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a><br>
<mailto:<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>><br></div><div><div class="h5">
<mailto:<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a> <mailto:<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>>>> wrote:<br>
<br>
> Hey Jason,<br>
><br>
> I don’t know about llgs or how much work it would be to<br>
change<br>
the kalimba gdbserver stub.<br>
><br>
> Currently GDBRemoteCommunicationServer, used by both<br>
llgs and<br>
lldb-platform, does send the triple as hex encoded via<br>
this code:<br>
><br>
> response.PutCString("triple:")<u></u>;<br>
><br>
response.PutCStringAsRawHex8(<u></u>host_triple.getTriple().c_str(<u></u>));<br>
><br>
> We can easily not do that as you suggest. Are there any<br>
ramifications for your usage of lldb-platform, though?<br>
We’d need<br>
to change the receiver code of that, which would then<br>
differ based<br>
on which lldb-platform version you’re talking to.<br>
<br>
It sounds like Matthew is open to changing the kalimba<br>
stub. We<br>
should get rid of the hex-ascii strings (along with<br>
distribution_id, os_build, os_kernel) everywhere.<br>
lldb-platform<br>
is not bundled/distributed in any products so we don't have to<br>
worry about deployed versions.<br>
<br>
hostname is less clear-cut because there we're dealing with a<br>
user-specified string and that may include one of # $ } *.<br>
<br>
Personally, I wish the whole of gdb-remote protocol<br>
required the<br>
use of the binary packet escape protocol which says that<br>
any of<br>
these 4 metacharacters that is meant to be sent in the<br>
body of a<br>
packet is prefixed with } and is xor'ed with 0x20. But<br>
that's not<br>
what the protocol says so we need to do these things..<br>
<br>
<br>
<br>
<br>
-- Todd Fiala | Software Engineer | <a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a><br></div></div>
<mailto:<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>> <mailto:<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a><br>
<mailto:<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>>> | <a href="tel:650-943-3180" value="+16509433180" target="_blank">650-943-3180</a> <tel:<a href="tel:650-943-3180" value="+16509433180" target="_blank">650-943-3180</a>><div class="">
<br>
<br>
<br>
<br>
<br>
To report this email as spam click here<br>
<<a href="https://www.mailcontrol.com/sr/MZbqvYs5QwJvpeaetUwhCQ==" target="_blank">https://www.mailcontrol.com/<u></u>sr/MZbqvYs5QwJvpeaetUwhCQ==</a>>.<br>
<br>
<br>
<br>
<br>
Member of the CSR plc group of companies. CSR plc registered in<br>
England and Wales, registered number 4187346, registered office<br>
Churchill House, Cambridge Business Park, Cowley Road, Cambridge,<br>
CB4 0WZ, United Kingdom<br></div>
More information can be found at <a href="http://www.csr.com" target="_blank">www.csr.com</a> <<a href="http://www.csr.com" target="_blank">http://www.csr.com</a>>.<div class=""><br>
Keep up to date with CSR on our technical blog, <a href="http://www.csr.com/blog" target="_blank">www.csr.com/blog</a><br></div>
<<a href="http://www.csr.com/blog" target="_blank">http://www.csr.com/blog</a>>, CSR people blog, <a href="http://www.csr.com/people" target="_blank">www.csr.com/people</a><br>
<<a href="http://www.csr.com/people" target="_blank">http://www.csr.com/people</a>>, YouTube, <a href="http://www.youtube.com/user/CSRplc" target="_blank">www.youtube.com/user/CSRplc</a><br>
<<a href="http://www.youtube.com/user/CSRplc" target="_blank">http://www.youtube.com/user/<u></u>CSRplc</a>>, Facebook,<br>
<a href="http://www.facebook.com/pages/CSR/191038434253534" target="_blank">www.facebook.com/pages/CSR/<u></u>191038434253534</a><br>
<<a href="http://www.facebook.com/pages/CSR/191038434253534" target="_blank">http://www.facebook.com/<u></u>pages/CSR/191038434253534</a>>, or follow us<br>
on Twitter at <a href="http://www.twitter.com/CSR_plc" target="_blank">www.twitter.com/CSR_plc</a><br>
<<a href="http://www.twitter.com/CSR_plc" target="_blank">http://www.twitter.com/CSR_<u></u>plc</a>>.<div class=""><br>
New for 2014, you can now access the wide range of products<br></div>
powered by aptX at <a href="http://www.aptx.com" target="_blank">www.aptx.com</a> <<a href="http://www.aptx.com" target="_blank">http://www.aptx.com</a>>.<div class=""><br>
<br>
<br>
<br>
<br>
-- <br>
Todd Fiala | Software Engineer | <a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a> <mailto:<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>> | <a href="tel:650-943-3180" value="+16509433180" target="_blank">650-943-3180</a><br>
<br>
<br>
</div></blockquote>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>