<div dir="ltr">On Sun, Jul 20, 2014 at 1:17 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Was this the warning about mismatched keyword arguments?  If so, big +1 and thanks for fixing this.  Was very annoying.</div>
</blockquote><div><br></div><div>Yeah, that is what it was.  You're quite welcome :-).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb">
<div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jul 19, 2014 at 10:28 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: compnerd<br>
Date: Sun Jul 20 00:28:55 2014<br>
New Revision: 213469<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=213469&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=213469&view=rev</a><br>
Log:<br>
build: fix cmake warning with newer CMake<br>
<br>
Hoist the compatibility macros out a level and re-use them when adding link<br>
dependencies.  Silences a warning from CMake.<br>
<br>
Modified:<br>
    lldb/trunk/CMakeLists.txt<br>
    lldb/trunk/source/CMakeLists.txt<br>
<br>
Modified: lldb/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=213469&r1=213468&r2=213469&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=213469&r1=213468&r2=213469&view=diff</a><br>


==============================================================================<br>
--- lldb/trunk/CMakeLists.txt (original)<br>
+++ lldb/trunk/CMakeLists.txt Sun Jul 20 00:28:55 2014<br>
@@ -197,6 +197,16 @@ string(REGEX MATCH "[0-9]+\\.[0-9]+(\\.[<br>
   ${PACKAGE_VERSION})<br>
 message(STATUS "LLDB version: ${LLDB_VERSION}")<br>
<br>
+if (CMAKE_VERSION VERSION_LESS 2.8.12)<br>
+  set(cmake_2_8_12_INTERFACE)<br>
+  set(cmake_2_8_12_PRIVATE)<br>
+  set(cmake_2_8_12_PUBLIC)<br>
+else ()<br>
+  set(cmake_2_8_12_INTERFACE INTERFACE)<br>
+  set(cmake_2_8_12_PRIVATE PRIVATE)<br>
+  set(cmake_2_8_12_PUBLIC PUBLIC)<br>
+endif ()<br>
+<br>
 macro(add_lldb_library name)<br>
   llvm_process_sources(srcs ${ARGN})<br>
   if (MSVC_IDE OR XCODE)<br>
@@ -222,16 +232,6 @@ macro(add_lldb_library name)<br>
   ##add_dependencies(${name} ${LLVM_COMMON_DEPENDS})<br>
   #endif()<br>
<br>
-  if (CMAKE_VERSION VERSION_LESS 2.8.12)<br>
-    set(cmake_2_8_12_INTERFACE)<br>
-    set(cmake_2_8_12_PRIVATE)<br>
-    set(cmake_2_8_12_PUBLIC)<br>
-  else ()<br>
-    set(cmake_2_8_12_INTERFACE INTERFACE)<br>
-    set(cmake_2_8_12_PRIVATE PRIVATE)<br>
-    set(cmake_2_8_12_PUBLIC PUBLIC)<br>
-  endif ()<br>
-<br>
   if ("${libkind}" STREQUAL "STATIC")<br>
     set(lldb_library_keyword ${cmake_2_8_12_INTERFACE})<br>
   else ()<br>
<br>
Modified: lldb/trunk/source/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/CMakeLists.txt?rev=213469&r1=213468&r2=213469&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/CMakeLists.txt?rev=213469&r1=213468&r2=213469&view=diff</a><br>


==============================================================================<br>
--- lldb/trunk/source/CMakeLists.txt (original)<br>
+++ lldb/trunk/source/CMakeLists.txt Sun Jul 20 00:28:55 2014<br>
@@ -300,7 +300,7 @@ if (LLDB_WRAP_PYTHON OR LLDB_VERS_GENERA<br>
     ${LLDB_VERS_GENERATED_FILE}<br>
     )<br>
 endif()<br>
-target_link_libraries(liblldb ${LLDB_SYSTEM_LIBS})<br>
+target_link_libraries(liblldb ${cmake_2_8_12_PRIVATE} ${LLDB_SYSTEM_LIBS})<br>
<br>
 # Determine LLDB revision and repository. GetSourceVersion and GetRepositoryPath are shell-scripts, and as<br>
 # such will not work on Windows.<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div>