<div dir="ltr">Thanks, good catch. Can you confirm that it works without that? If so I'll make the necessary adjustment locally but no need to re-upload a new patch since it's so simple.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 11:37 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>Typo:</div><div class=""><div><br></div>> <span style="font-family:arial,sans-serif;font-size:12.7272720336914px"> for expect on MacOSX to be able to load pexpect.</span><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px"><br>
</span></div></div><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px">for the <b>lldb tests </b>on MacOSX to be able to load pexpect.</span></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">
On Fri, Jul 18, 2014 at 11:36 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><p style="margin:1.2em 0px!important">Ok definitely related to changes in test/dotest.py.</p>
<p style="margin:1.2em 0px!important">Let me see if I can adjust that. The key is you’re nuking the custom pexpect-2.4 path, which is absolutely needed for expect on MacOSX to be able to load pexpect.</p>
<p style="margin:1.2em 0px!important">I think if you don’t nuke this part:</p>
<pre style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;font-size:1em;line-height:1.2em;margin:1.2em 0px"><code style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(234,234,234);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;display:inline;background-color:rgb(248,248,248);white-space:pre-wrap;overflow:auto;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;border:1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important;display:block;padding:0.5em;color:rgb(51,51,51);background:rgb(248,248,255)"><span>===================================================================</span>
<span>--- test/dotest.py (revision 213388)</span>
<span>+++ test/dotest.py (working copy)</span>
<span style="color:rgb(170,170,170)">@@ -883,12 +883,7 @@</span><div>
os.environ["LLDB_SRC"] = os.path.join(sys.path[0], os.pardir)
pluginPath = os.path.join(scriptPath, 'plugins')
<span style="background:rgb(255,221,221)">- pexpectPath = os.path.join(scriptPath, 'pexpect-2.4')</span>
<span style="background:rgb(255,221,221)">- # Put embedded pexpect at front of the load path so we ensure we</span>
<span style="background:rgb(255,221,221)">- # use that version.</span>
<span style="background:rgb(255,221,221)">- sys.path.insert(0, pexpectPath)</span>
<span style="background:rgb(255,221,221)">-</span></div>
# Append script dir and plugin dir to the sys.path.
sys.path.append(scriptPath)
sys.path.append(pluginPath)
</code></pre>
<p style="margin:1.2em 0px!important">everything would probably be fine.</p>
<div title="MDH:T2sgZGVmaW5pdGVseSByZWxhdGVkIHRvIGNoYW5nZXMgaW4gdGVzdC9kb3Rlc3QucHkuPGRpdj48
YnI+PC9kaXY+PGRpdj5MZXQgbWUgc2VlIGlmIEkgY2FuIGFkanVzdCB0aGF0LiAmbmJzcDtUaGUg
a2V5IGlzIHlvdSdyZSBudWtpbmcgdGhlIGN1c3RvbSBwZXhwZWN0LTIuNCBwYXRoLCB3aGljaCBp
cyBhYnNvbHV0ZWx5IG5lZWRlZCBmb3IgZXhwZWN0IG9uIE1hY09TWCB0byBiZSBhYmxlIHRvIGxv
YWQgcGV4cGVjdC48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PkkgdGhpbmsgaWYgeW91IGRvbid0
IG51a2UgdGhpcyBwYXJ0OjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+YGBgZGlmZjwvZGl2Pjxk
aXY+PGRpdj49PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PC9kaXY+PGRpdj4tLS0gdGVzdC9kb3Rlc3QucHk8c3BhbiBjbGFz
cz0iIiBzdHlsZT0id2hpdGUtc3BhY2U6IHByZTsiPgk8L3NwYW4+KHJldmlzaW9uIDIxMzM4OCk8
L2Rpdj48ZGl2PisrKyB0ZXN0L2RvdGVzdC5weTxzcGFuIGNsYXNzPSIiIHN0eWxlPSJ3aGl0ZS1z
cGFjZTogcHJlOyI+CTwvc3Bhbj4od29ya2luZyBjb3B5KTwvZGl2PjxkaXY+QEAgLTg4MywxMiAr
ODgzLDcgQEA8L2Rpdj48ZGl2PiZuYnNwOyAmbmJzcDsgJm5ic3A7b3MuZW52aXJvblsiTExEQl9T
UkMiXSA9IG9zLnBhdGguam9pbihzeXMucGF0aFswXSwgb3MucGFyZGlyKTwvZGl2PjxkaXY+Jm5i
c3A7PC9kaXY+PGRpdj4mbmJzcDsgJm5ic3A7ICZuYnNwO3BsdWdpblBhdGggPSBvcy5wYXRoLmpv
aW4oc2NyaXB0UGF0aCwgJ3BsdWdpbnMnKTwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7cGV4cGVj
dFBhdGggPSBvcy5wYXRoLmpvaW4oc2NyaXB0UGF0aCwgJ3BleHBlY3QtMi40Jyk8L2Rpdj48ZGl2
PiZuYnNwOzwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7IyBQdXQgZW1iZWRkZWQgcGV4cGVjdCBh
dCBmcm9udCBvZiB0aGUgbG9hZCBwYXRoIHNvIHdlIGVuc3VyZSB3ZTwvZGl2PjxkaXY+LSAmbmJz
cDsgJm5ic3A7IyB1c2UgdGhhdCB2ZXJzaW9uLjwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7c3lz
LnBhdGguaW5zZXJ0KDAsIHBleHBlY3RQYXRoKTwvZGl2PjxkaXY+LTwvZGl2PjxkaXY+Jm5ic3A7
ICZuYnNwOyAmbmJzcDsjIEFwcGVuZCBzY3JpcHQgZGlyIGFuZCBwbHVnaW4gZGlyIHRvIHRoZSBz
eXMucGF0aC48L2Rpdj48ZGl2PiZuYnNwOyAmbmJzcDsgJm5ic3A7c3lzLnBhdGguYXBwZW5kKHNj
cmlwdFBhdGgpPC9kaXY+PGRpdj4mbmJzcDsgJm5ic3A7ICZuYnNwO3N5cy5wYXRoLmFwcGVuZChw
bHVnaW5QYXRoKTwvZGl2PjwvZGl2PjxkaXY+YGBgPC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5l
dmVyeXRoaW5nIHdvdWxkIHByb2JhYmx5IGJlIGZpbmUuPC9kaXY+" style="min-height:0;font-size:0em;padding:0;margin:0"></div></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Jul 18, 2014 at 11:32 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Oh it has to do with the pexpect (embedded - needs to show up in pythonpath) not being found on MacOSX.<div>
<br></div><div>(I think pexpect comes embedded on most Linux distros, so wouldn't show up there).</div>
<div><br></div><div>Let me see what went wrong. We use the pexpect from the lldb/test dir usually.</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 11:28 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm, so I need to investigate but right now all the tests are failing on MacOSX with this change.<div><br>
</div><div>I'm going to reverse it out and make sure something isn't whack on my laptop.</div>
</div><div class="gmail_extra"><div><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 9:33 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Checking on this now.<br>
<br>
<a href="http://reviews.llvm.org/D4548" target="_blank">http://reviews.llvm.org/D4548</a><br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div></div><span><font color="#888888">-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'">
<tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br></div>