<div dir="ltr"><div class="markdown-here-wrapper" style><p style="margin:1.2em 0px!important">That last comment was related to this here:</p>
<blockquote style="margin:1.2em 0px;border-left-width:4px;border-left-style:solid;border-left-color:rgb(221,221,221);padding:0px 1em;color:rgb(119,119,119);quotes:none">
<p style="margin:1.2em 0px!important">Okay, down to one test failure on MacOSX. Looking at that in a moment.</p>
</blockquote>
<p style="margin:1.2em 0px!important">It’s running fine on MacOSX if you chop off that section I indicated earlier (which is how I tested it here).</p>
<p style="margin:1.2em 0px!important">The complete test/dotest.py diff I was using on MacOSX was this:</p>
<pre style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;font-size:1em;line-height:1.2em;margin:1.2em 0px"><code style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(234,234,234);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;display:inline;background-color:rgb(248,248,248);white-space:pre;overflow:auto;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;border:1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important;display:block;padding:0.5em;color:rgb(51,51,51);background:rgb(248,248,255)">Index: test/dotest.py
===================================================================
--- test/dotest.py (revision 213388)
+++ test/dotest.py (working copy)
@@ -1004,17 +1004,17 @@
# If our lldb supports the -P option, use it to find the python path:
init_in_python_dir = 'lldb/__init__.py'
- import pexpect
lldb_dash_p_result = None
if lldbHere:
- lldb_dash_p_result = pexpect.run("%s -P"%(lldbHere))
+ lldb_dash_p_result = subprocess.check_output("%s -P"%(lldbHere), stderr=subprocess.STDOUT)
elif lldbExec:
- lldb_dash_p_result = pexpect.run("%s -P"%(lldbExec))
+ lldb_dash_p_result = subprocess.check_output("%s -P"%(lldbExec), stderr=subprocess.STDOUT)
- if lldb_dash_p_result and not lldb_dash_p_result.startswith(("<", "lldb: invalid option:")):
+ if lldb_dash_p_result and not lldb_dash_p_result.startswith(("<", "lldb: invalid option:")) \
+ and not lldb_dash_p_result.startswith("Traceback"):
lines = lldb_dash_p_result.splitlines()
- if len(lines) == 1 and os.path.isfile(os.path.join(lines[0], init_in_python_dir)):
+ if len(lines) >= 1 and os.path.isfile(os.path.join(lines[0], init_in_python_dir)):
lldbPath = lines[0]
if "freebsd" in sys.platform or "linux" in sys.platform:
os.environ['LLDB_LIB_DIR'] = os.path.join(lldbPath, '..', '..')
</code></pre><p style="margin:1.2em 0px!important">Note the Linux subprocess issue still exists with this tweak. </p>
<div title="MDH:PHAgc3R5bGU9ImZvbnQtZmFtaWx5OiBhcmlhbCwgc2Fucy1zZXJpZjsgZm9udC1zaXplOiAxMi43
MjcyNzIwMzM2OTE0cHg7IG1hcmdpbjogMS4yZW0gMHB4ICFpbXBvcnRhbnQ7Ij5UaGF0IGxhc3Qg
Y29tbWVudCB3YXMgcmVsYXRlZCB0byB0aGlzIGhlcmU6PC9wPjxwIHN0eWxlPSJmb250LWZhbWls
eTogYXJpYWwsIHNhbnMtc2VyaWY7IGZvbnQtc2l6ZTogMTIuNzI3MjcyMDMzNjkxNHB4OyBtYXJn
aW46IDEuMmVtIDBweCAhaW1wb3J0YW50OyI+Jmd0OyBPa2F5LCBkb3duIHRvIG9uZSB0ZXN0IGZh
aWx1cmUgb24gTWFjT1NYLiBMb29raW5nIGF0IHRoYXQgaW4gYSBtb21lbnQuPC9wPjxkaXY+SXQn
cyBydW5uaW5nIGZpbmUgb24gTWFjT1NYIGlmIHlvdSBjaG9wIG9mZiB0aGF0IHNlY3Rpb24gSSBp
bmRpY2F0ZWQgZWFybGllciAod2hpY2ggaXMgaG93IEkgdGVzdGVkIGl0IGhlcmUpLjwvZGl2Pjxk
aXY+PGJyPjwvZGl2PjxkaXY+VGhlIGNvbXBsZXRlIHRlc3QvZG90ZXN0LnB5IGRpZmYgSSB3YXMg
dXNpbmcgb24gTWFjT1NYIHdhcyB0aGlzOjwvZGl2PjxkaXY+YGBgPC9kaXY+PGRpdj5JbmRleDog
dGVzdC9kb3Rlc3QucHk8L2Rpdj48ZGl2Pj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT08L2Rpdj48ZGl2Pi0tLSB0ZXN0L2Rv
dGVzdC5weTxzcGFuIGNsYXNzPSIiIHN0eWxlPSJ3aGl0ZS1zcGFjZTogcHJlOyI+CTwvc3Bhbj4o
cmV2aXNpb24gMjEzMzg4KTwvZGl2PjxkaXY+KysrIHRlc3QvZG90ZXN0LnB5PHNwYW4gY2xhc3M9
IiIgc3R5bGU9IndoaXRlLXNwYWNlOiBwcmU7Ij4JPC9zcGFuPih3b3JraW5nIGNvcHkpPC9kaXY+
PGRpdj5AQCAtMTAwNCwxNyArMTAwNCwxNyBAQDwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyAmbmJz
cDsgJm5ic3A7ICZuYnNwOzwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOyMgSWYgb3VyIGxsZGIgc3VwcG9ydHMgdGhlIC1QIG9wdGlvbiwgdXNlIGl0IHRvIGZpbmQg
dGhlIHB5dGhvbiBwYXRoOjwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwO2luaXRfaW5fcHl0aG9uX2RpciA9ICdsbGRiL19faW5pdF9fLnB5JzwvZGl2PjxkaXY+LSAm
bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDtpbXBvcnQgcGV4cGVjdDwvZGl2PjxkaXY+Jm5ic3A7
ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwO2xsZGJfZGFzaF9wX3Jlc3VsdCA9IE5vbmU8L2Rp
dj48ZGl2PiZuYnNwOzwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNw
O2lmIGxsZGJIZXJlOjwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5i
c3A7ICZuYnNwO2xsZGJfZGFzaF9wX3Jlc3VsdCA9IHBleHBlY3QucnVuKCIlcyAtUCIlKGxsZGJI
ZXJlKSk8L2Rpdj48ZGl2PisgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJz
cDtsbGRiX2Rhc2hfcF9yZXN1bHQgPSBzdWJwcm9jZXNzLmNoZWNrX291dHB1dCgiJXMgLVAiJShs
bGRiSGVyZSksIHN0ZGVycj1zdWJwcm9jZXNzLlNURE9VVCk8L2Rpdj48ZGl2PiZuYnNwOyAmbmJz
cDsgJm5ic3A7ICZuYnNwOyAmbmJzcDtlbGlmIGxsZGJFeGVjOjwvZGl2PjxkaXY+LSAmbmJzcDsg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwO2xsZGJfZGFzaF9wX3Jlc3VsdCA9IHBl
eHBlY3QucnVuKCIlcyAtUCIlKGxsZGJFeGVjKSk8L2Rpdj48ZGl2PisgJm5ic3A7ICZuYnNwOyAm
bmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDtsbGRiX2Rhc2hfcF9yZXN1bHQgPSBzdWJwcm9jZXNz
LmNoZWNrX291dHB1dCgiJXMgLVAiJShsbGRiRXhlYyksIHN0ZGVycj1zdWJwcm9jZXNzLlNURE9V
VCk8L2Rpdj48ZGl2PiZuYnNwOzwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJz
cDtpZiBsbGRiX2Rhc2hfcF9yZXN1bHQgYW5kIG5vdCBsbGRiX2Rhc2hfcF9yZXN1bHQuc3RhcnRz
d2l0aCgoIiZsdDsiLCAibGxkYjogaW52YWxpZCBvcHRpb246IikpOjwvZGl2PjxkaXY+KyAmbmJz
cDsgJm5ic3A7ICZuYnNwOyAmbmJzcDtpZiBsbGRiX2Rhc2hfcF9yZXN1bHQgYW5kIG5vdCBsbGRi
X2Rhc2hfcF9yZXN1bHQuc3RhcnRzd2l0aCgoIiZsdDsiLCAibGxkYjogaW52YWxpZCBvcHRpb246
IikpIFw8L2Rpdj48ZGl2Pis8c3BhbiBjbGFzcz0iIiBzdHlsZT0id2hpdGUtc3BhY2U6IHByZTsi
PgkJCQkJCQk8L3NwYW4+ICZuYnNwO2FuZCBub3QgbGxkYl9kYXNoX3BfcmVzdWx0LnN0YXJ0c3dp
dGgoIlRyYWNlYmFjayIpOjwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZu
YnNwOyAmbmJzcDsgJm5ic3A7bGluZXMgPSBsbGRiX2Rhc2hfcF9yZXN1bHQuc3BsaXRsaW5lcygp
PC9kaXY+PGRpdj4tICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7aWYg
bGVuKGxpbmVzKSA9PSAxIGFuZCBvcy5wYXRoLmlzZmlsZShvcy5wYXRoLmpvaW4obGluZXNbMF0s
IGluaXRfaW5fcHl0aG9uX2RpcikpOjwvZGl2PjxkaXY+KyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAm
bmJzcDsgJm5ic3A7ICZuYnNwO2lmIGxlbihsaW5lcykgJmd0Oz0gMSBhbmQgb3MucGF0aC5pc2Zp
bGUob3MucGF0aC5qb2luKGxpbmVzWzBdLCBpbml0X2luX3B5dGhvbl9kaXIpKTo8L2Rpdj48ZGl2
PiZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg
Jm5ic3A7bGxkYlBhdGggPSBsaW5lc1swXTwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyAmbmJzcDsg
Jm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDtpZiAiZnJlZWJzZCIgaW4g
c3lzLnBsYXRmb3JtIG9yICJsaW51eCIgaW4gc3lzLnBsYXRmb3JtOjwvZGl2PjxkaXY+Jm5ic3A7
ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDsg
Jm5ic3A7ICZuYnNwO29zLmVudmlyb25bJ0xMREJfTElCX0RJUiddID0gb3MucGF0aC5qb2luKGxs
ZGJQYXRoLCAnLi4nLCAnLi4nKTwvZGl2PjxkaXY+YGBgPGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2
PjxkaXY+Tm90ZSB0aGUgTGludXggc3VicHJvY2VzcyBpc3N1ZSBzdGlsbCBleGlzdHMgd2l0aCB0
aGlzIHR3ZWFrLiZuYnNwOzwvZGl2Pg==" style="height:0;font-size:0em;padding:0;margin:0"></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 12:10 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The MacOSX failure you can ignore. It wasn't related and runs fine over here now.</div><div class="HOEnZb">
<div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 11:54 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><p style="margin:1.2em 0px!important">Okay, down to one test failure on MacOSX. Looking at that in a moment.</p>
<p style="margin:1.2em 0px!important">Now on Linux. Getting issues with subprocess calls. The first one looks like this (and none of the tests are making it to the running phase there):</p>
<pre style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;font-size:1em;line-height:1.2em;margin:1.2em 0px"><code style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(234,234,234);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;display:inline;background-color:rgb(248,248,248);white-space:pre-wrap;overflow:auto;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;border:1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important;display:block;padding:0.5em;color:rgb(51,51,51);background:rgb(248,248,255)"> File "/mnt/ssd/work/macosx.sync/mbp-svn/build-debug/../llvm/tools/lldb/test/dotest.py", line 1218, in <module>
setupSysPath()
File "/mnt/ssd/work/macosx.sync/mbp-svn/build-debug/../llvm/tools/lldb/test/dotest.py", line 1010, in setupSysPath
lldb_dash_p_result = subprocess.check_output("%s -P"%(lldbHere), stderr=subprocess.STDOUT)
File "/usr/lib/python2.7/subprocess.py", line 566, in check_output
process = Popen(stdout=PIPE, *popenargs, **kwargs)
File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
</code></pre><p style="margin:1.2em 0px!important">Back after I look into those.</p>
<div title="MDH:T2theSwgZG93biB0byBvbmUgdGVzdCBmYWlsdXJlIG9uIE1hY09TWC4gwqBMb29raW5nIGF0IHRo
YXQgaW4gYSBtb21lbnQuPGRpdj48ZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+Tm93IG9uIExpbnV4
LiAmbmJzcDtHZXR0aW5nIGlzc3VlcyB3aXRoIHN1YnByb2Nlc3MgY2FsbHMuICZuYnNwO1RoZSBm
aXJzdCBvbmUgbG9va3MgbGlrZSB0aGlzIChhbmQgbm9uZSBvZiB0aGUgdGVzdHMgYXJlIG1ha2lu
ZyBpdCB0byB0aGUgcnVubmluZyBwaGFzZSB0aGVyZSk6PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRp
dj5gYGA8L2Rpdj48ZGl2PjxkaXY+Jm5ic3A7IEZpbGUgIi9tbnQvc3NkL3dvcmsvbWFjb3N4LnN5
bmMvbWJwLXN2bi9idWlsZC1kZWJ1Zy8uLi9sbHZtL3Rvb2xzL2xsZGIvdGVzdC9kb3Rlc3QucHki
LCBsaW5lIDEyMTgsIGluICZsdDttb2R1bGUmZ3Q7PC9kaXY+PGRpdj4mbmJzcDsgJm5ic3A7IHNl
dHVwU3lzUGF0aCgpPC9kaXY+PGRpdj4mbmJzcDsgRmlsZSAiL21udC9zc2Qvd29yay9tYWNvc3gu
c3luYy9tYnAtc3ZuL2J1aWxkLWRlYnVnLy4uL2xsdm0vdG9vbHMvbGxkYi90ZXN0L2RvdGVzdC5w
eSIsIGxpbmUgMTAxMCwgaW4gc2V0dXBTeXNQYXRoPC9kaXY+PGRpdj4mbmJzcDsgJm5ic3A7IGxs
ZGJfZGFzaF9wX3Jlc3VsdCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KCIlcyAtUCIlKGxsZGJI
ZXJlKSwgc3RkZXJyPXN1YnByb2Nlc3MuU1RET1VUKTwvZGl2PjxkaXY+Jm5ic3A7IEZpbGUgIi91
c3IvbGliL3B5dGhvbjIuNy9zdWJwcm9jZXNzLnB5IiwgbGluZSA1NjYsIGluIGNoZWNrX291dHB1
dDwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyBwcm9jZXNzID0gUG9wZW4oc3Rkb3V0PVBJUEUsICpw
b3BlbmFyZ3MsICoqa3dhcmdzKTwvZGl2PjxkaXY+Jm5ic3A7IEZpbGUgIi91c3IvbGliL3B5dGhv
bjIuNy9zdWJwcm9jZXNzLnB5IiwgbGluZSA3MTAsIGluIF9faW5pdF9fPC9kaXY+PGRpdj4mbmJz
cDsgJm5ic3A7IGVycnJlYWQsIGVycndyaXRlKTwvZGl2PjxkaXY+Jm5ic3A7IEZpbGUgIi91c3Iv
bGliL3B5dGhvbjIuNy9zdWJwcm9jZXNzLnB5IiwgbGluZSAxMzI3LCBpbiBfZXhlY3V0ZV9jaGls
ZDwvZGl2PjxkaXY+Jm5ic3A7ICZuYnNwOyByYWlzZSBjaGlsZF9leGNlcHRpb248L2Rpdj48ZGl2
Pk9TRXJyb3I6IFtFcnJubyAyXSBObyBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5PC9kaXY+PC9kaXY+
PGRpdj5gYGA8L2Rpdj48L2Rpdj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PkJhY2sgYWZ0ZXIg
SSBsb29rIGludG8gdGhvc2UuPC9kaXY+" style="min-height:0;font-size:0em;padding:0;margin:0"></div></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 11:39 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yep I'll try that out now.</div><div><div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Fri, Jul 18, 2014 at 11:38 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks, good catch. Can you confirm that it works without that? If so I'll make the necessary adjustment locally but no need to re-upload a new patch since it's so simple.</div>
<div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 11:37 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>Typo:</div><div><div><br></div>> <span style="font-family:arial,sans-serif;font-size:12.7272720336914px"> for expect on MacOSX to be able to load pexpect.</span><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px"><br>
</span></div></div><div><span style="font-family:arial,sans-serif;font-size:12.7272720336914px">for the <b>lldb tests </b>on MacOSX to be able to load pexpect.</span></div></div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">
On Fri, Jul 18, 2014 at 11:36 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><p style="margin:1.2em 0px!important">Ok definitely related to changes in test/dotest.py.</p>
<p style="margin:1.2em 0px!important">Let me see if I can adjust that. The key is you’re nuking the custom pexpect-2.4 path, which is absolutely needed for expect on MacOSX to be able to load pexpect.</p>
<p style="margin:1.2em 0px!important">I think if you don’t nuke this part:</p>
<pre style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;font-size:1em;line-height:1.2em;margin:1.2em 0px"><code style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(234,234,234);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;display:inline;background-color:rgb(248,248,248);white-space:pre-wrap;overflow:auto;border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;border:1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important;display:block;padding:0.5em;color:rgb(51,51,51);background:rgb(248,248,255)"><span>===================================================================</span>
<span>--- test/dotest.py (revision 213388)</span>
<span>+++ test/dotest.py (working copy)</span>
<span style="color:rgb(170,170,170)">@@ -883,12 +883,7 @@</span><div>
os.environ["LLDB_SRC"] = os.path.join(sys.path[0], os.pardir)
pluginPath = os.path.join(scriptPath, 'plugins')
<span style="background:rgb(255,221,221)">- pexpectPath = os.path.join(scriptPath, 'pexpect-2.4')</span>
<span style="background:rgb(255,221,221)">- # Put embedded pexpect at front of the load path so we ensure we</span>
<span style="background:rgb(255,221,221)">- # use that version.</span>
<span style="background:rgb(255,221,221)">- sys.path.insert(0, pexpectPath)</span>
<span style="background:rgb(255,221,221)">-</span></div>
# Append script dir and plugin dir to the sys.path.
sys.path.append(scriptPath)
sys.path.append(pluginPath)
</code></pre>
<p style="margin:1.2em 0px!important">everything would probably be fine.</p>
<div title="MDH:T2sgZGVmaW5pdGVseSByZWxhdGVkIHRvIGNoYW5nZXMgaW4gdGVzdC9kb3Rlc3QucHkuPGRpdj48
YnI+PC9kaXY+PGRpdj5MZXQgbWUgc2VlIGlmIEkgY2FuIGFkanVzdCB0aGF0LiAmbmJzcDtUaGUg
a2V5IGlzIHlvdSdyZSBudWtpbmcgdGhlIGN1c3RvbSBwZXhwZWN0LTIuNCBwYXRoLCB3aGljaCBp
cyBhYnNvbHV0ZWx5IG5lZWRlZCBmb3IgZXhwZWN0IG9uIE1hY09TWCB0byBiZSBhYmxlIHRvIGxv
YWQgcGV4cGVjdC48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PkkgdGhpbmsgaWYgeW91IGRvbid0
IG51a2UgdGhpcyBwYXJ0OjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+YGBgZGlmZjwvZGl2Pjxk
aXY+PGRpdj49PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PC9kaXY+PGRpdj4tLS0gdGVzdC9kb3Rlc3QucHk8c3BhbiBjbGFz
cz0iIiBzdHlsZT0id2hpdGUtc3BhY2U6IHByZTsiPgk8L3NwYW4+KHJldmlzaW9uIDIxMzM4OCk8
L2Rpdj48ZGl2PisrKyB0ZXN0L2RvdGVzdC5weTxzcGFuIGNsYXNzPSIiIHN0eWxlPSJ3aGl0ZS1z
cGFjZTogcHJlOyI+CTwvc3Bhbj4od29ya2luZyBjb3B5KTwvZGl2PjxkaXY+QEAgLTg4MywxMiAr
ODgzLDcgQEA8L2Rpdj48ZGl2PiZuYnNwOyAmbmJzcDsgJm5ic3A7b3MuZW52aXJvblsiTExEQl9T
UkMiXSA9IG9zLnBhdGguam9pbihzeXMucGF0aFswXSwgb3MucGFyZGlyKTwvZGl2PjxkaXY+Jm5i
c3A7PC9kaXY+PGRpdj4mbmJzcDsgJm5ic3A7ICZuYnNwO3BsdWdpblBhdGggPSBvcy5wYXRoLmpv
aW4oc2NyaXB0UGF0aCwgJ3BsdWdpbnMnKTwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7cGV4cGVj
dFBhdGggPSBvcy5wYXRoLmpvaW4oc2NyaXB0UGF0aCwgJ3BleHBlY3QtMi40Jyk8L2Rpdj48ZGl2
PiZuYnNwOzwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7IyBQdXQgZW1iZWRkZWQgcGV4cGVjdCBh
dCBmcm9udCBvZiB0aGUgbG9hZCBwYXRoIHNvIHdlIGVuc3VyZSB3ZTwvZGl2PjxkaXY+LSAmbmJz
cDsgJm5ic3A7IyB1c2UgdGhhdCB2ZXJzaW9uLjwvZGl2PjxkaXY+LSAmbmJzcDsgJm5ic3A7c3lz
LnBhdGguaW5zZXJ0KDAsIHBleHBlY3RQYXRoKTwvZGl2PjxkaXY+LTwvZGl2PjxkaXY+Jm5ic3A7
ICZuYnNwOyAmbmJzcDsjIEFwcGVuZCBzY3JpcHQgZGlyIGFuZCBwbHVnaW4gZGlyIHRvIHRoZSBz
eXMucGF0aC48L2Rpdj48ZGl2PiZuYnNwOyAmbmJzcDsgJm5ic3A7c3lzLnBhdGguYXBwZW5kKHNj
cmlwdFBhdGgpPC9kaXY+PGRpdj4mbmJzcDsgJm5ic3A7ICZuYnNwO3N5cy5wYXRoLmFwcGVuZChw
bHVnaW5QYXRoKTwvZGl2PjwvZGl2PjxkaXY+YGBgPC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5l
dmVyeXRoaW5nIHdvdWxkIHByb2JhYmx5IGJlIGZpbmUuPC9kaXY+" style="min-height:0;font-size:0em;padding:0;margin:0"></div></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Jul 18, 2014 at 11:32 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Oh it has to do with the pexpect (embedded - needs to show up in pythonpath) not being found on MacOSX.<div>
<br></div><div>(I think pexpect comes embedded on most Linux distros, so wouldn't show up there).</div>
<div><br></div><div>Let me see what went wrong. We use the pexpect from the lldb/test dir usually.</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 11:28 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm, so I need to investigate but right now all the tests are failing on MacOSX with this change.<div><br>
</div><div>I'm going to reverse it out and make sure something isn't whack on my laptop.</div>
</div><div class="gmail_extra"><div><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 9:33 AM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Checking on this now.<br>
<br>
<a href="http://reviews.llvm.org/D4548" target="_blank">http://reviews.llvm.org/D4548</a><br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div></div><span><font color="#888888">-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'">
<tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>