<div dir="ltr">I'll give this a run and check it in after an all clear, later today.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 14, 2014 at 3:55 PM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks good.<br>
<div><div class="h5"><br>
> On Jul 13, 2014, at 9:59 AM, Paul Osmialowski <<a href="mailto:pawelo@king.net.pl">pawelo@king.net.pl</a>> wrote:<br>
><br>
> New improved version posted.<br>
><br>
> <a href="http://reviews.llvm.org/D4381" target="_blank">http://reviews.llvm.org/D4381</a><br>
><br>
> Files:<br>
> include/lldb/Core/ArchSpec.h<br>
> source/Core/ArchSpec.cpp<br>
><br>
> Index: include/lldb/Core/ArchSpec.h<br>
> ===================================================================<br>
> --- include/lldb/Core/ArchSpec.h<br>
> +++ include/lldb/Core/ArchSpec.h<br>
> @@ -64,6 +64,8 @@<br>
> eCore_thumbv7m,<br>
> eCore_thumbv7em,<br>
> eCore_arm_arm64,<br>
> + eCore_arm_armv8,<br>
> + eCore_arm_aarch64,<br>
><br>
> eCore_mips64,<br>
><br>
> Index: source/Core/ArchSpec.cpp<br>
> ===================================================================<br>
> --- source/Core/ArchSpec.cpp<br>
> +++ source/Core/ArchSpec.cpp<br>
> @@ -78,6 +78,8 @@<br>
> { eByteOrderLittle, 4, 2, 4, llvm::Triple::thumb , ArchSpec::eCore_thumbv7m , "thumbv7m" },<br>
> { eByteOrderLittle, 4, 2, 4, llvm::Triple::thumb , ArchSpec::eCore_thumbv7em , "thumbv7em" },<br>
> { eByteOrderLittle, 8, 4, 4, llvm::Triple::arm64 , ArchSpec::eCore_arm_arm64 , "arm64" },<br>
> + { eByteOrderLittle, 8, 4, 4, llvm::Triple::arm64 , ArchSpec::eCore_arm_armv8 , "armv8" },<br>
> + { eByteOrderLittle, 8, 4, 4, llvm::Triple::arm64 , ArchSpec::eCore_arm_aarch64 , "aarch64" },<br>
><br>
> { eByteOrderBig , 8, 4, 4, llvm::Triple::mips64 , ArchSpec::eCore_mips64 , "mips64" },<br>
><br>
> @@ -248,6 +250,7 @@<br>
> { ArchSpec::eCore_ppc_generic , llvm::ELF::EM_PPC , LLDB_INVALID_CPUTYPE, 0xFFFFFFFFu, 0xFFFFFFFFu }, // PowerPC<br>
> { ArchSpec::eCore_ppc64_generic , llvm::ELF::EM_PPC64 , LLDB_INVALID_CPUTYPE, 0xFFFFFFFFu, 0xFFFFFFFFu }, // PowerPC64<br>
> { ArchSpec::eCore_arm_generic , llvm::ELF::EM_ARM , LLDB_INVALID_CPUTYPE, 0xFFFFFFFFu, 0xFFFFFFFFu }, // ARM<br>
> + { ArchSpec::eCore_arm_aarch64 , llvm::ELF::EM_AARCH64, LLDB_INVALID_CPUTYPE, 0xFFFFFFFFu, 0xFFFFFFFFu }, // ARM64<br>
> { ArchSpec::eCore_sparc9_generic , llvm::ELF::EM_SPARCV9, LLDB_INVALID_CPUTYPE, 0xFFFFFFFFu, 0xFFFFFFFFu }, // SPARC V9<br>
> { ArchSpec::eCore_x86_64_x86_64 , llvm::ELF::EM_X86_64 , LLDB_INVALID_CPUTYPE, 0xFFFFFFFFu, 0xFFFFFFFFu }, // AMD64<br>
> { ArchSpec::eCore_mips64 , llvm::ELF::EM_MIPS , LLDB_INVALID_CPUTYPE, 0xFFFFFFFFu, 0xFFFFFFFFu }, // MIPS<br>
> @@ -963,6 +966,39 @@<br>
> }<br>
> break;<br>
><br>
> + case ArchSpec::eCore_arm_armv8:<br>
> + if (!enforce_exact_match)<br>
> + {<br>
> + if (core2 == ArchSpec::eCore_arm_arm64)<br>
> + return true;<br>
> + if (core2 == ArchSpec::eCore_arm_aarch64)<br>
> + return true;<br>
> + try_inverse = false;<br>
> + }<br>
> + break;<br>
> +<br>
> + case ArchSpec::eCore_arm_aarch64:<br>
> + if (!enforce_exact_match)<br>
> + {<br>
> + if (core2 == ArchSpec::eCore_arm_arm64)<br>
> + return true;<br>
> + if (core2 == ArchSpec::eCore_arm_armv8)<br>
> + return true;<br>
> + try_inverse = false;<br>
> + }<br>
> + break;<br>
> +<br>
> + case ArchSpec::eCore_arm_arm64:<br>
> + if (!enforce_exact_match)<br>
> + {<br>
> + if (core2 == ArchSpec::eCore_arm_aarch64)<br>
> + return true;<br>
> + if (core2 == ArchSpec::eCore_arm_armv8)<br>
> + return true;<br>
> + try_inverse = false;<br>
> + }<br>
> + break;<br>
> +<br>
> default:<br>
> break;<br>
> }<br>
</div></div>> <D4381.11352.patch>_______________________________________________<br>
<div class="HOEnZb"><div class="h5">> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>