<div dir="ltr">In fact enough talk about them being intermittent. I'll go ahead and disable them on Linux with bugs filed. We really should have a clean test run on Linux, and follow up on addressing those.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Jul 7, 2014 at 1:39 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">(There's also a TestGdbRemoteExpeditedRegisters - my test - fails under heavy load occasionally).</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 7, 2014 at 1:37 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'll have a run through with it and then I'll submit it.<div><br></div><div>Here are the tests that currently fail for me intermittently on Linux:</div>
<div><br></div><div>TestConvenienceVariables.py</div>
<div>TestFormatters.py</div><div>TestLongjmp.py</div><div>Test-rdar-9974002.py</div><div>TestWatchpointMultipleThreads.py</div><div><br></div><div>There might be one more in there, but those are the set I see most frequently at TOT.</div>
</div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Mon, Jul 7, 2014 at 12:52 PM, Randy Smith <span dir="ltr"><<a href="mailto:rdsmith@chromium.org" target="_blank">rdsmith@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Mon, Jul 7, 2014 at 2:33 PM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks fine to me if the test suite is happy with the changes.<br></blockquote><div><br></div></div><div>No failures on Linux other than failures I've also seen on trunk (TestConvenienceVariables.py is consistently failing on Linux for me).</div>
<div><br></div><div>Willing to land it for me? This is my first patch, so unless I'm told differently (:-}) I'm going with the LLVM process of submitting patches for a while rather than asking for commit access up front. (I do intend to make multiple contributions to lldb over the coming weeks/months.)</div>
<div><br></div><div>Thanks!</div><span><font color="#888888"><div><br></div><div>-- Randy</div></font></span><div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Greg<br>
<div><div><br>
> On Jul 3, 2014, at 11:42 AM, Randy Smith <<a href="mailto:rdsmith@chromium.org" target="_blank">rdsmith@chromium.org</a>> wrote:<br>
><br>
><br>
> Based on r212225. I've sketched out my rationale for this change in <a href="http://llvm.org/bugs/show_bug.cgi?id=20149" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=20149</a>. It's fairly simple; is someone willing to take a look?<br>
><br>
> Note that I don't (yet) have commit access, so if this patch is approved someone will need to land it for me. (I found the LLVM and LLDB pages not completely consistent around the process for gaining commit access, so I'm going with the LLVM "contribute several patches and then ask".)<br>
><br>
> I ran the "check-lldb" test suite on Linux, and found no difference in results between r212225 and r212225+my patch. (As a side note, what should I expect from the Linux test suite? TestConvenienceVariables.py is failing for me at top of tree.)<br>
><br>
> -- Randy<br>
><br>
</div></div>> <sourcedisp.diff>_______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br>
</blockquote></div></div><br></div></div>
<br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'">
<tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>