<div dir="ltr">Sorry about that. Your patch looks good to me. </div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 24, 2014 at 8:46 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This patch broke the Windows build, and also I believe had a bug.  I've uploaded a fix here [<a href="http://reviews.llvm.org/D4284" target="_blank">http://reviews.llvm.org/D4284</a>] if someone doesn't mind taking a look.</div>

<div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 24, 2014 at 3:32 PM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
% svn commit<br>
Sending        include/lldb/Core/Section.h<br>
Sending        lib/Makefile<br>
Sending        source/Core/Section.cpp<br>
Sending        source/Expression/IRExecutionUnit.cpp<br>
Sending        source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp<br>
Sending        source/Plugins/Makefile<br>
Sending        source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp<br>
Sending        source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp<br>
Sending        source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp<br>
Transmitting file data .........<br>
Committed revision 211638.<br>
<br>
I committed the changes, but left it disabled by default on apple vendors because of performance regressions that caused us to disable this in the first place. We can talk about how and when we enable this when vendor == apple in the near future.<br>



<span><font color="#888888"><br>
Greg<br>
</font></span><div><div><br>
> On Jun 24, 2014, at 3:03 PM, Keno Fischer <<a href="mailto:kfischer@college.harvard.edu" target="_blank">kfischer@college.harvard.edu</a>> wrote:<br>
><br>
> Ok, great! I don't have commit access, so would you mind committing this?<br>
><br>
><br>
> On Tue, Jun 24, 2014 at 5:50 PM, Greg Clayton <<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>> wrote:<br>
> Looks good.<br>
><br>
> > On Jun 19, 2014, at 10:41 AM, Keno Fischer <<a href="mailto:kfischer@college.harvard.edu" target="_blank">kfischer@college.harvard.edu</a>> wrote:<br>
> ><br>
> > Slight adjustment to updateSectionLoadAddress to properly adjust the load address range of fake segments.<br>
> ><br>
> > <a href="http://reviews.llvm.org/D4006" target="_blank">http://reviews.llvm.org/D4006</a><br>
> ><br>
> > Files:<br>
> >  include/lldb/Core/Section.h<br>
> >  lib/Makefile<br>
> >  source/Core/Section.cpp<br>
> >  source/Expression/IRExecutionUnit.cpp<br>
> >  source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp<br>
> >  source/Plugins/Makefile<br>
> >  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp<br>
> >  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp<br>
> >  source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp<br>
> > <D4006.10646.patch>_______________________________________________<br>
> > lldb-commits mailing list<br>
> > <a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
><br>
><br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>