<div dir="ltr">Hi Todd,<div>yes, it's failing on my OS X. I would too expect <span style="font-family:arial,sans-serif;font-size:13px">LLVM_COMPILER_IS_GCC_</span><span style="font-family:arial,sans-serif;font-size:13px">COMPATIBLE to be false, but HandleLLVMStdlib.cmake says otherwise:</span><div>
<span style="font-family:arial,sans-serif;font-size:13px"><br></span></div> if(CMAKE_COMPILER_IS_GNUCXX)<br> set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)<br> elseif( MSVC )<br> set(LLVM_COMPILER_IS_GCC_COMPATIBLE OFF)<br>
elseif( "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" )<br> set(LLVM_COMPILER_IS_GCC_COMPATIBLE ON)<br> endif()<div><br></div><div>Kuba</div></div><div><br></div></div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Mon, Jun 16, 2014 at 5:28 PM, Todd Fiala <span dir="ltr"><<a href="mailto:tfiala@google.com" target="_blank">tfiala@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi Kuba,<div><br></div><div>I've been running on both MacOSX and Linux with the change in place. On MacOSX I'm using the canonical MacOSX build, Xcode-based. It's been a while since I built MacOSX with cmake primarily because I cannot get that build to run any tests successfully on my end.</div>
<div><br></div><div>Have you tried it on OSX and it's failing? I would expect LLVM_COMPILER_IS_GCC_COMPATIBLE to be false on MacOSX and thus for the check to be no change w/r/t cmake MacOSX if I read it right.</div>
</div>
<div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Mon, Jun 16, 2014 at 3:08 PM, Kuba Břečka <span dir="ltr"><<a href="mailto:kuba.brecka@gmail.com" target="_blank">kuba.brecka@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><div><div>I think this patch breaks builds on default OS X systems. Or is there anything else than just "cmake ../llvm; make" for OS X?</div>
<div><br></div><div>Kuba</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Modified: lldb/trunk/CMakeLists.txt<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=210035&r1=210034&r2=210035&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=210035&r1=210034&r2=210035&view=diff</a><br>
==============================================================================<br>--- lldb/trunk/CMakeLists.txt (original)<br>+++ lldb/trunk/CMakeLists.txt Mon Jun 2 12:30:22 2014<br>@@ -218,9 +218,7 @@ macro(add_lldb_library name)<br>
endif ()<br> <br> if(LLDB_USED_LIBS)<br>- if (CMAKE_SYSTEM_NAME MATCHES "Linux" OR<br>- CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR<br>- CMAKE_SYSTEM_NAME MATCHES "Windows")<br>
+ if (LLVM_COMPILER_IS_GCC_COMPATIBLE)<br> target_link_libraries(${name} ${cmake_2_8_12_PUBLIC}<br> -Wl,--start-group ${LLDB_USED_LIBS} -Wl,--end-group)<br> else()</blockquote></div>
<div><br></div><div><br></div></div>
<br></div></div>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'">
<tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</font></span></div>
</blockquote></div><br></div>