<div dir="ltr"><div>> <span style="font-family:arial,sans-serif;font-size:12.727272033691406px">Sorry, my bad. I think I jumped the gun here!</span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br>
</span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">No sweat, we've all been there :-)</span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br>
</span></div><div>> <span style="font-family:arial,sans-serif;font-size:12.727272033691406px">However, what do you (and others!) think of the discrepancy between the qHostInfo and qProcessInfo docs?</span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br>
</span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">My take on it is that while it is not ideal that they're different bases, they are spec'd out right and the code in the field behaves the way it is spec'd out.</span></div>
<div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">If we were to leave the client code the same and switch the qHostInfo to be hex, as long as we prepended the 0x to the qHostInfo generation in RNBRemote.cpp and GDBRemoteCommunicationServer.cpp, I think it would all still work. (Existing older debugserver/lldb-platform would write decimal in a 0-base client friendly way and get interpreted correctly, and newer debugserver/lldb-platform/llgs would prepend a 0x and also get proper client interpretation due to the 0-base client code. And since the code is the same on the client for old/new, the matrix of old/new stub and old/new client would probably work. But I'd never mess with production code just for the benefit of making the spec look cleaner (and changing the spec in the process). So my vote would be to leave it as it is.</span></div>
<div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">But that's just my 2 cents ;-)</span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 11, 2014 at 11:35 PM, Matthew Gardiner <span dir="ltr"><<a href="mailto:mg11@csr.com" target="_blank">mg11@csr.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Todd Fiala wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey Matthew,<br>
<br><div class="">
That 0 parameter to strtoul doesn't quite work like that. The 0 indicates that the input character string determines how the base is interpreted. So a 0x{hex} will get interpreted base 16, a standard non-zero-leading set of decimal numbers is base 10, and a 0{octal} is octal.<br>
<br>
<br>
</div></blockquote>
Sorry, my bad. I think I jumped the gun here! However, the documentation in lldb-gdb-remote.txt does state that for qHostInfo:<div class=""><br>
<br>
cputype: is a number that is the mach-o CPU type that is being debugged (base 10)<br>
<br></div>
but for qProcessInfo:<br>
cputype: the Mach-O CPU type of the process (base 16)<br>
<br>
So I wondered whether bases of either message were intended to be different. That's why I think something is a bit wrong in the docs. Then I looked at the parsing code, and unfortunately misinterpreted the 0 specification :-(<br>
<br>
However, what do you (and others!) think of the discrepancy between the qHostInfo and qProcessInfo docs?<div class="HOEnZb"><div class="h5"><br>
<br>
Matt<br>
<br>
<br>
<br>
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom<br>
More information can be found at <a href="http://www.csr.com" target="_blank">www.csr.com</a>. Keep up to date with CSR on our technical blog, <a href="http://www.csr.com/blog" target="_blank">www.csr.com/blog</a>, CSR people blog, <a href="http://www.csr.com/people" target="_blank">www.csr.com/people</a>, YouTube, <a href="http://www.youtube.com/user/CSRplc" target="_blank">www.youtube.com/user/CSRplc</a>, Facebook, <a href="http://www.facebook.com/pages/CSR/191038434253534" target="_blank">www.facebook.com/pages/CSR/<u></u>191038434253534</a>, or follow us on Twitter at <a href="http://www.twitter.com/CSR_plc" target="_blank">www.twitter.com/CSR_plc</a>.<br>
New for 2014, you can now access the wide range of products powered by aptX at <a href="http://www.aptx.com" target="_blank">www.aptx.com</a>.<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34);background-repeat:initial initial">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>