<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Mar 13, 2014 at 3:42 AM, Hafiz Abid Qadeer <span dir="ltr"><<a href="mailto:hafiz_abid@mentor.com" target="_blank">hafiz_abid@mentor.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: abidh<br>
Date: Thu Mar 13 05:42:28 2014<br>
New Revision: 203781<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=203781&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=203781&view=rev</a><br>
Log:<br>
Hide some declarations from mingw.<br></blockquote><div><br></div><div>Given this description, I don't think that this change is the proper way to handle this.  Can you change the #ifdef _MSC_VER to if !defined(__MINGW32__) please?  _MSC_VER indicates that you are using either the Microsoft compiler or clang with Microsoft compatibility.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Modified:<br>
    lldb/trunk/tools/driver/Platform.cpp<br>
    lldb/trunk/tools/driver/Platform.h<br>
<br>
Modified: lldb/trunk/tools/driver/Platform.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Platform.cpp?rev=203781&r1=203780&r2=203781&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Platform.cpp?rev=203781&r1=203780&r2=203781&view=diff</a><br>

==============================================================================<br>
--- lldb/trunk/tools/driver/Platform.cpp (original)<br>
+++ lldb/trunk/tools/driver/Platform.cpp Thu Mar 13 05:42:28 2014<br>
@@ -84,6 +84,7 @@ tcgetattr (int fildes, struct termios *t<br>
     return -1;<br>
 }<br>
<br>
+#ifdef _MSC_VER<br>
 sighandler_t<br>
 signal (int sig, sighandler_t sigFunc)<br>
 {<br>
@@ -106,5 +107,6 @@ signal (int sig, sighandler_t sigFunc)<br>
     }<br>
     return 0;<br>
 }<br>
+#endif<br>
<br>
 #endif<br>
<br>
Modified: lldb/trunk/tools/driver/Platform.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Platform.h?rev=203781&r1=203780&r2=203781&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Platform.h?rev=203781&r1=203780&r2=203781&view=diff</a><br>

==============================================================================<br>
--- lldb/trunk/tools/driver/Platform.h (original)<br>
+++ lldb/trunk/tools/driver/Platform.h Thu Mar 13 05:42:28 2014<br>
@@ -16,18 +16,13 @@<br>
<br>
     // this will stop signal.h being included<br>
     #define _INC_SIGNAL<br>
-<br>
     #include <io.h><br>
+#if defined( _MSC_VER )<br>
     #include <eh.h><br>
+#endif<br>
     #include <inttypes.h><br>
     #include "lldb/Host/windows/windows.h"<br>
<br>
-    struct timeval<br>
-    {<br>
-        long tv_sec;<br>
-        long tv_usec;<br>
-    };<br>
-<br>
     struct winsize<br>
     {<br>
         long ws_col;<br>
@@ -65,13 +60,8 @@<br>
         speed_t c_ospeed;  // output speed<br>
     };<br>
<br>
-    typedef long pid_t;<br>
-<br>
     #define STDIN_FILENO 0<br>
<br>
-    #define PATH_MAX MAX_PATH<br>
-    #define snprintf _snprintf<br>
-<br>
     extern int  ioctl( int d, int request, ... );<br>
     extern int  kill ( pid_t pid, int sig      );<br>
     extern int  tcsetattr( int fd, int optional_actions, const struct termios *termios_p );<br>
@@ -86,7 +76,18 @@<br>
     #define SIG_DFL ( (sighandler_t) -1 )<br>
     // ignored<br>
     #define SIG_IGN ( (sighandler_t) -2 )<br>
+<br>
+#ifdef _MSC_VER<br>
+    struct timeval<br>
+    {<br>
+        long tv_sec;<br>
+        long tv_usec;<br>
+    };<br>
+    typedef long pid_t;<br>
+    #define snprintf _snprintf<br>
     extern sighandler_t signal( int sig, sighandler_t );<br>
+    #define PATH_MAX MAX_PATH<br>
+#endif<br>
<br>
 #else<br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div>