
<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Let me investigate this.</div><div><br></div><div>My gut feeling is we might not be fetching the file globals anymore. We might need to fetch them and append them to our local VariableList.</div><div><br></div><div>The easy way to verify this would be to grab the frame's VariableList in the global case and AppendIfUnique it to the one we made from the block.</div><div><br></div><div>I am not in the office now but can verify later or feel free to play with it yourself of course.</div><div><br>Sent from the iPhone of<div><i>Enrico Granata</i> <egranata@🍎.com></div></div><div><br>On Feb 19, 2014, at 8:36 AM, Ed Maste <<a href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>> wrote:<br><br></div><blockquote type="cite"><div><span>On 18 February 2014 18:48, Enrico Granata <<a href="mailto:egranata@apple.com">egranata@apple.com</a>> wrote:</span><br><blockquote type="cite"><span>Author: enrico</span><br></blockquote><blockquote type="cite"><span>Date: Tue Feb 18 17:48:11 2014</span><br></blockquote><blockquote type="cite"><span>New Revision: 201614</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=201614&view=rev">http://llvm.org/viewvc/llvm-project?rev=201614&view=rev</a></span><br></blockquote><blockquote type="cite"><span>Log:</span><br></blockquote><blockquote type="cite"><span><<a href="rdar://problem/15960553">rdar://problem/15960553</a>></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Fix a bug where calling SBFrame::FindValue() would cause a copy of all variables in the block to be inserted in the frame's variable list, regardless of whether those same variables were there or not - which means one could end up with a frame with lots of duplicate copies of the same variables</span><br></blockquote><span></span><br><span>After this change I see 10 new test failures (listed below); I haven't</span><br><span>yet investigated if the tests are buggy, or if something else is now</span><br><span>broken.</span><br><span></span><br><span>test_access_my_int_with_dwarf TestProcessAPI ProcessAPITestCase</span><br><span>test_read_memory_with_dwarf TestProcessAPI ProcessAPITestCase</span><br><span>test_set_watch_ignore_count_with_dwarf TestWatchpointIgnoreCount</span><br><span>WatchpointIgnoreCountTestCase</span><br><span>test_watch_address_with_dwarf TestTargetWatchAddress</span><br><span>TargetWatchAddressAPITestCase</span><br><span>test_watch_iter_with_dwarf TestWatchpointIter WatchpointIteratorTestCase</span><br><span>test_watch_location_with_dwarf TestSetWatchlocation SetWatchlocationAPITestCase</span><br><span>test_watch_val_with_dwarf TestSetWatchpoint SetWatchpointAPITestCase</span><br><span>test_watchpoint_cond_api_with_dwarf TestWatchpointConditionAPI</span><br><span>WatchpointConditionAPITestCase</span><br><span>test_with_dwarf_and_python_api TestStaticVariables StaticVariableTestCase</span><br><span>test_write_memory_with_dwarf TestProcessAPI ProcessAPITestCase</span><br></div></blockquote></body></html>