<div dir="ltr"><div><font face="arial, helvetica, sans-serif">Proposed change:</font></div><div><font face="arial, helvetica, sans-serif"><br></font></div><div><font face="arial, helvetica, sans-serif">convert gdb-remote 'A' launch to use LaunchProcess ()</font><br>
</div><div><font face="arial, helvetica, sans-serif"><br></font></div><div><font face="arial, helvetica, sans-serif">This change modifies the 'A' command handler's launch code to launch with LaunchProcess (). The net effect is that the default process monitoring that LaunchProcess () adds will kick in, allowing the GDBRemoteCommunicationServer to be able to reap processes started with this facility correctly. Later, in the case of lldb-gdbserver, we'll also have the proper process monitoring going on to really debug the inferior process.</font></div>
<div><font face="arial, helvetica, sans-serif"><br></font></div><div><font face="arial, helvetica, sans-serif">Any issues with this? This code runs both in lldb-gdbserver and lldb-platform.</font></div><div><font face="courier new, monospace" size="1"><br>
</font></div><div><font face="courier new, monospace" size="1">===================================================================</font></div><div><font face="courier new, monospace" size="1">--- source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp<span class="" style="white-space:pre"> </span>(revision 200226)</font></div>
<div><font face="courier new, monospace" size="1">+++ source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp<span class="" style="white-space:pre"> </span>(working copy)</font></div><div><font face="courier new, monospace" size="1">@@ -811,8 +811,11 @@</font></div>
<div><font face="courier new, monospace" size="1"> </font></div><div><font face="courier new, monospace" size="1"> if (success)</font></div><div><font face="courier new, monospace" size="1"> {</font></div><div><font face="courier new, monospace" size="1">+ // FIXME: remove linux restriction once eLaunchFlagDebug is supported</font></div>
<div><font face="courier new, monospace" size="1">+#if !defined (__linux__)</font></div><div><font face="courier new, monospace" size="1"> m_process_launch_info.GetFlags().Set (eLaunchFlagDebug);</font></div><div>
<font face="courier new, monospace" size="1">- m_process_launch_error = Host::LaunchProcess (m_process_launch_info);</font></div><div><font face="courier new, monospace" size="1">+#endif</font></div><div><font face="courier new, monospace" size="1">+ m_process_launch_error = LaunchProcess ();</font></div>
<div><font face="courier new, monospace" size="1"> if (m_process_launch_info.GetProcessID() != LLDB_INVALID_PROCESS_ID)</font></div><div><font face="courier new, monospace" size="1"> {</font></div><div><font face="courier new, monospace" size="1"> return SendOKResponse ();</font></div>
<div><br></div><div><br></div>-- <br><div dir="ltr"><table cellspacing="0" cellpadding="0" style="color:rgb(136,136,136);font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small">
<td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Todd Fiala |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tfiala@google.com" style="color:rgb(17,85,204)" target="_blank"><span style="background-color:rgb(255,255,204);color:rgb(34,34,34)">tfiala@google.com</span></a> |</td>
<td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"><font color="#1155cc"> <a>650-943-3180</a></font></td></tr></tbody></table><br></div>
</div>