<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Ping. Could you please confirm if the
WindowsDriver patch(<a class="moz-txt-link-freetext"
href="http://llvm-reviews.chandlerc.com/D1785">http://llvm-reviews.chandlerc.com/D1785</a>)
and the PlatformWindows patch(<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://llvm-reviews.chandlerc.com/D1772">http://llvm-reviews.chandlerc.com/D1772</a>)
are now okay to be committed to trunk?<br>
I've obtained commit-after-approval access.<br>
<br>
Thanks,<br>
Deepak<br>
<br>
On 10/10/13 15:45, Deepak Panickal wrote:<br>
</div>
<blockquote cite="mid:5256BD7F.5050303@codeplay.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi,<br>
<br>
I have updated the PlatformWindows patch with the changes that
Greg and João suggested. I tried using clang-format for the
patch but seems like LLDB style is not supported and the LLVM
style looks quite different.<br>
<br>
We're still working on the Windows Driver patch. If the
PlatformWindows patch looks okay, then could we commit it to
trunk? Could you please advise on how to obtain commit access?<br>
<br>
Thanks,<br>
Deepak<br>
<br>
On 10/10/13 15:34, Deepak Panickal wrote:<br>
</div>
<blockquote
cite="mid:632b4ce4b1ca9a60cc98c2ae10d04122@llvm-reviews.chandlerc.com"
type="cite">
<pre wrap=""> Enable PlatformWIndows on other plaforms as Greg suggested
Fixed up spacing issues as per João.
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://llvm-reviews.chandlerc.com/D1772">http://llvm-reviews.chandlerc.com/D1772</a>
CHANGE SINCE LAST DIFF
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://llvm-reviews.chandlerc.com/D1772?vs=4576&id=4806#toc">http://llvm-reviews.chandlerc.com/D1772?vs=4576&id=4806#toc</a>
Files:
source/CMakeLists.txt
source/Plugins/Platform/CMakeLists.txt
source/Plugins/Platform/Windows/CMakeLists.txt
source/Plugins/Platform/Windows/PlatformWindows.cpp
source/Plugins/Platform/Windows/PlatformWindows.h
source/lldb.cpp
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
lldb-commits mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>