<div dir="ltr">Yes sorry I meant <initializer_list>.<div><br><div>Actually I thought this include was explicitely needed for MSVC12 port...</div><div>but I've just been testing again, it seems not necessary anymore, maybe it was fixed in the latest version -- my bad.</div>
<div><br></div><div>However for this specific case with <span style="font-family:arial,sans-serif;font-size:13px">std::pair, it felt easier to just use normal constructor instead of initializer_list since it doesn't make code much different</span></div>
<div><font face="arial, sans-serif">(as opposed to cases such as std::vector<int> a = { 1, 1, 1 } where it makes much more sense vs using many verbose push_back).</font></div><div><font face="arial, sans-serif"><br>
</font></div><div><span style="font-family:arial,sans-serif">Also, even though it's not a big priority for me, it should also make it easier to maintain a future MSVC11 branch (which doesn't support initializer_list) by using this feature only where it actually matters, so that it minimizes differences.</span><br>
</div><div><span style="font-family:arial,sans-serif"><br></span></div><div><span style="font-family:arial,sans-serif">Of course I won't try to remove it from all the other useful situations where it's used.</span></div>
<div><span style="font-family:arial,sans-serif"><br></span></div><div><span style="font-family:arial,sans-serif">Hopes that make sense, and let me know if you prefer me to revert, no problem for me.</span></div><div><font face="arial, sans-serif"><br>
</font></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 28, 2013 at 3:06 AM, Enrico Granata <span dir="ltr"><<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>I think you meant <initializer_list> rather than <functional></div>
With that said, why do we care to “remove the need” for this header?<div>
Is that just because we can easily do without in this case, or is there a more deep-rooted reason?</div><div>If the latter, since it is a standard header, it worries me a little.<span class="HOEnZb"><font color="#888888"><br>
</font></span><div><div><div><span class="HOEnZb"><font color="#888888"><br><div>
<div style="text-indent:0px;letter-spacing:normal;text-align:start;text-transform:none;white-space:normal;word-wrap:break-word;word-spacing:0px"><div style="text-indent:0px;letter-spacing:normal;text-align:start;text-transform:none;white-space:normal;word-wrap:break-word;word-spacing:0px">
<div style="border-collapse:separate;border-spacing:0px"><span style="font-size:12px">Enrico Granata</span><br style="font-size:12px"><span style="font-size:12px">📩 egranata@</span><font color="#ff2600" style="font-size:12px"></font><span style="font-size:12px">.com</span><br style="font-size:12px">
<span style="font-size:12px">☎️ 27683</span></div></div></div>
</div></font></span><div><div class="h5">
<br><div><div>On Aug 27, 2013, at 9:22 AM, Virgile Bello <<a href="mailto:virgile.bello@gmail.com" target="_blank">virgile.bello@gmail.com</a>> wrote:</div><br><blockquote type="cite">Author: xen2<br>Date: Tue Aug 27 11:22:29 2013<br>
New Revision: 189365<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189365&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=189365&view=rev</a><br>Log:<br>Remove need of <functional> for CommandObjectCommands.<br>
<br>Modified:<br> lldb/trunk/source/Commands/CommandObjectCommands.cpp<br><br>Modified: lldb/trunk/source/Commands/CommandObjectCommands.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectCommands.cpp?rev=189365&r1=189364&r2=189365&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectCommands.cpp?rev=189365&r1=189364&r2=189365&view=diff</a><br>
==============================================================================<br>--- lldb/trunk/source/Commands/CommandObjectCommands.cpp (original)<br>+++ lldb/trunk/source/Commands/CommandObjectCommands.cpp Tue Aug 27 11:22:29 2013<br>
@@ -156,9 +156,9 @@ protected:<br> }<br> else<br> {<br>- std::pair<bool,uint64_t> start_idx = {m_options.m_start_idx.OptionWasSet(),m_options.m_start_idx.GetCurrentValue()};<br>
- std::pair<bool,uint64_t> stop_idx = {m_options.m_stop_idx.OptionWasSet(),m_options.m_stop_idx.GetCurrentValue()};<br>- std::pair<bool,uint64_t> count = {m_options.m_count.OptionWasSet(),m_options.m_count.GetCurrentValue()};<br>
+ std::pair<bool,uint64_t> start_idx(m_options.m_start_idx.OptionWasSet(),m_options.m_start_idx.GetCurrentValue());<br>+ std::pair<bool,uint64_t> stop_idx(m_options.m_stop_idx.OptionWasSet(),m_options.m_stop_idx.GetCurrentValue());<br>
+ std::pair<bool,uint64_t> count(m_options.m_count.OptionWasSet(),m_options.m_count.GetCurrentValue());<br><br> const CommandHistory& history(m_interpreter.GetCommandHistory());<br>
<br><br><br>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div></div></div></div></div></div></div></blockquote></div><br></div>