<div dir="ltr">Sure - Please provide the diffs as attachment.<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 19, 2013 at 1:48 PM, Ed Maste <span dir="ltr"><<a href="mailto:emaste@freebsd.org" target="_blank">emaste@freebsd.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 18 July 2013 14:26, Samuel Jacob <<a href="mailto:samueldotj@gmail.com">samueldotj@gmail.com</a>> wrote:<br>
</div><div class="im">> Looks good to me.<br>
> Please attach patch, so that I can test on my Linux cores.<br>
<br>
</div>Thanks for testing the changes Samuel.<br>
<br>
I've sent another couple of patches to the list to improve parsing<br>
vendor-specific notes and handle thread names on FreeBSD. (An earlier<br>
version of the thread name patch put the new FreeBSD-specific types in<br>
the same enum, which might end up with a conflict.) Subsequent work<br>
will clean up the note parsing for PRSTATUS and PSINFO, removing the<br>
compile-time #ifdefs.<br>
<br>
Do you mind reviewing and trying the patch set on Linux?<br>
<br>
The three patches in the set are:<br>
[PATCH] DataExtractor: Add fixed length field string fn<br>
[PATCH 1/2] elf-core: Parse vendor-specific notes<br>
[PATCH 2/2] elf-core: Parse FreeBSD thread names<br>
<br>
(I can forward them as attachments if you wish.)<br>
</blockquote></div><br></div>