Shouldn't we set it back to what it was before, after finishing the test?<div>Some tests have failed in the past due to settings being set for one completely orthogonal test.</div><div><br></div><div>Regards,</div><div>
<br></div><div> Filipe</div><div class="gmail_extra"><br clear="all"> F<br><br>
<br><br><div class="gmail_quote">On Tue, Nov 20, 2012 at 10:53 AM, Daniel Malea <span dir="ltr"><<a href="mailto:daniel.malea@intel.com" target="_blank">daniel.malea@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: dmalea<br>
Date: Tue Nov 20 12:53:21 2012<br>
New Revision: 168375<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=168375&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=168375&view=rev</a><br>
Log:<br>
Use auto-confirm setting to avoid prompts causing some tests to appear to hang<br>
- this commit addresses bugzilla #14385<br>
<br>
<br>
Modified:<br>
lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py<br>
lldb/trunk/test/types/TestFloatTypes.py<br>
lldb/trunk/test/types/TestFloatTypesExpr.py<br>
lldb/trunk/test/types/TestIntegerTypes.py<br>
lldb/trunk/test/types/TestIntegerTypesExpr.py<br>
<br>
Modified: lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py?rev=168375&r1=168374&r2=168375&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py?rev=168375&r1=168374&r2=168375&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py (original)<br>
+++ lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py Tue Nov 20 12:53:21 2012<br>
@@ -26,7 +26,6 @@<br>
self.breakpoint_command_sequence()<br>
self.breakpoint_command_script_parameters ()<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_with_dwarf(self):<br>
"""Test a sequence of breakpoint command add, list, and delete."""<br>
@@ -39,6 +38,8 @@<br>
TestBase.setUp(self)<br>
# Find the line number to break inside main().<br>
self.line = line_number('main.c', '// Set break point at this line.')<br>
+ # disable "There is a running process, kill it and restart?" prompt<br>
+ self.runCmd("settings set auto-confirm true")<br>
<br>
def breakpoint_command_sequence(self):<br>
"""Test a sequence of breakpoint command add, list, and delete."""<br>
<br>
Modified: lldb/trunk/test/types/TestFloatTypes.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestFloatTypes.py?rev=168375&r1=168374&r2=168375&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestFloatTypes.py?rev=168375&r1=168374&r2=168375&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/test/types/TestFloatTypes.py (original)<br>
+++ lldb/trunk/test/types/TestFloatTypes.py Tue Nov 20 12:53:21 2012<br>
@@ -12,6 +12,12 @@<br>
<br>
mydir = "types"<br>
<br>
+ def setUp(self):<br>
+ # Call super's setUp().<br>
+ AbstractBase.GenericTester.setUp(self)<br>
+ # disable "There is a running process, kill it and restart?" prompt<br>
+ self.runCmd("settings set auto-confirm true")<br>
+<br>
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")<br>
@dsym_test<br>
def test_float_type_with_dsym(self):<br>
@@ -24,7 +30,6 @@<br>
"""Test that float-type variables are displayed correctly from a block."""<br>
self.build_and_run('float.cpp', set(['float']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_float_type_with_dwarf(self):<br>
"""Test that float-type variables are displayed correctly."""<br>
@@ -42,7 +47,6 @@<br>
"""Test that double-type variables are displayed correctly from a block."""<br>
self.build_and_run('double.cpp', set(['double']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_double_type_with_dwarf(self):<br>
"""Test that double-type variables are displayed correctly."""<br>
<br>
Modified: lldb/trunk/test/types/TestFloatTypesExpr.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestFloatTypesExpr.py?rev=168375&r1=168374&r2=168375&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestFloatTypesExpr.py?rev=168375&r1=168374&r2=168375&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/test/types/TestFloatTypesExpr.py (original)<br>
+++ lldb/trunk/test/types/TestFloatTypesExpr.py Tue Nov 20 12:53:21 2012<br>
@@ -15,6 +15,12 @@<br>
# rdar://problem/8493023<br>
# test/types failures for Test*TypesExpr.py: element offset computed wrong and sign error?<br>
<br>
+ def setUp(self):<br>
+ # Call super's setUp().<br>
+ AbstractBase.GenericTester.setUp(self)<br>
+ # disable "There is a running process, kill it and restart?" prompt<br>
+ self.runCmd("settings set auto-confirm true")<br>
+<br>
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")<br>
@dsym_test<br>
def test_float_type_with_dsym(self):<br>
@@ -27,7 +33,6 @@<br>
"""Test that float-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('float.cpp', set(['float']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_float_type_with_dwarf(self):<br>
"""Test that float-type variable expressions are evaluated correctly."""<br>
@@ -45,7 +50,6 @@<br>
"""Test that double-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('double.cpp', set(['double']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_double_type_with_dwarf(self):<br>
"""Test that double-type variable expressions are evaluated correctly."""<br>
<br>
Modified: lldb/trunk/test/types/TestIntegerTypes.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestIntegerTypes.py?rev=168375&r1=168374&r2=168375&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestIntegerTypes.py?rev=168375&r1=168374&r2=168375&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/test/types/TestIntegerTypes.py (original)<br>
+++ lldb/trunk/test/types/TestIntegerTypes.py Tue Nov 20 12:53:21 2012<br>
@@ -12,6 +12,12 @@<br>
<br>
mydir = "types"<br>
<br>
+ def setUp(self):<br>
+ # Call super's setUp().<br>
+ AbstractBase.GenericTester.setUp(self)<br>
+ # disable "There is a running process, kill it and restart?" prompt<br>
+ self.runCmd("settings set auto-confirm true")<br>
+<br>
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")<br>
@dsym_test<br>
def test_char_type_with_dsym(self):<br>
@@ -24,7 +30,6 @@<br>
"""Test that char-type variables are displayed correctly from a block."""<br>
self.build_and_run('char.cpp', set(['char']), bc=True, qd=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_char_type_with_dwarf(self):<br>
"""Test that char-type variables are displayed correctly."""<br>
@@ -42,7 +47,6 @@<br>
"""Test that 'unsigned char'-type variables are displayed correctly from a block."""<br>
self.build_and_run('unsigned_char.cpp', set(['unsigned', 'char']), bc=True, qd=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_char_type_with_dwarf(self):<br>
"""Test that 'unsigned char'-type variables are displayed correctly."""<br>
@@ -60,7 +64,6 @@<br>
"""Test that short-type variables are displayed correctly from a block."""<br>
self.build_and_run('short.cpp', set(['short']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_short_type_with_dwarf(self):<br>
"""Test that short-type variables are displayed correctly."""<br>
@@ -78,7 +81,6 @@<br>
"""Test that 'unsigned short'-type variables are displayed correctly from a block."""<br>
self.build_and_run('unsigned_short.cpp', set(['unsigned', 'short']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_short_type_with_dwarf(self):<br>
"""Test that 'unsigned short'-type variables are displayed correctly."""<br>
@@ -96,7 +98,6 @@<br>
"""Test that int-type variables are displayed correctly from a block."""<br>
self.build_and_run('int.cpp', set(['int']), dsym=False)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_int_type_with_dwarf(self):<br>
"""Test that int-type variables are displayed correctly."""<br>
@@ -114,7 +115,6 @@<br>
"""Test that 'unsigned int'-type variables are displayed correctly from a block."""<br>
self.build_and_run('unsigned_int.cpp', set(['unsigned', 'int']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_int_type_with_dwarf(self):<br>
"""Test that 'unsigned int'-type variables are displayed correctly."""<br>
@@ -132,7 +132,6 @@<br>
"""Test that long-type variables are displayed correctly from a block."""<br>
self.build_and_run('long.cpp', set(['long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_long_type_with_dwarf(self):<br>
"""Test that long-type variables are displayed correctly."""<br>
@@ -150,7 +149,6 @@<br>
"""Test that 'unsigned_long'-type variables are displayed correctly from a block."""<br>
self.build_and_run('unsigned_long.cpp', set(['unsigned', 'long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_long_type_with_dwarf(self):<br>
"""Test that 'unsigned long'-type variables are displayed correctly."""<br>
@@ -171,7 +169,6 @@<br>
"""Test that 'long_long'-type variables are displayed correctly from a block."""<br>
self.build_and_run('long_long.cpp', set(['long long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_long_long_type_with_dwarf(self):<br>
"""Test that 'long long'-type variables are displayed correctly."""<br>
@@ -189,7 +186,6 @@<br>
"""Test that 'unsigned_long_long'-type variables are displayed correctly from a block."""<br>
self.build_and_run('unsigned_long_long.cpp', set(['unsigned', 'long long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_long_long_type_with_dwarf(self):<br>
"""Test that 'unsigned long long'-type variables are displayed correctly."""<br>
<br>
Modified: lldb/trunk/test/types/TestIntegerTypesExpr.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestIntegerTypesExpr.py?rev=168375&r1=168374&r2=168375&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestIntegerTypesExpr.py?rev=168375&r1=168374&r2=168375&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/test/types/TestIntegerTypesExpr.py (original)<br>
+++ lldb/trunk/test/types/TestIntegerTypesExpr.py Tue Nov 20 12:53:21 2012<br>
@@ -12,6 +12,12 @@<br>
<br>
mydir = "types"<br>
<br>
+ def setUp(self):<br>
+ # Call super's setUp().<br>
+ AbstractBase.GenericTester.setUp(self)<br>
+ # disable "There is a running process, kill it and restart?" prompt<br>
+ self.runCmd("settings set auto-confirm true")<br>
+<br>
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")<br>
@dsym_test<br>
def test_char_type_with_dsym(self):<br>
@@ -24,7 +30,6 @@<br>
"""Test that char-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('char.cpp', set(['char']), bc=True, qd=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_char_type_with_dwarf(self):<br>
"""Test that char-type variable expressions are evaluated correctly."""<br>
@@ -42,7 +47,6 @@<br>
"""Test that 'unsigned char'-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('unsigned_char.cpp', set(['unsigned', 'char']), bc=True, qd=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_char_type_with_dwarf(self):<br>
"""Test that 'unsigned char'-type variable expressions are evaluated correctly."""<br>
@@ -60,7 +64,6 @@<br>
"""Test that short-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('short.cpp', set(['short']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_short_type_with_dwarf(self):<br>
"""Test that short-type variable expressions are evaluated correctly."""<br>
@@ -78,7 +81,6 @@<br>
"""Test that 'unsigned short'-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('unsigned_short.cpp', set(['unsigned', 'short']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_short_type_with_dwarf(self):<br>
"""Test that 'unsigned short'-type variable expressions are evaluated correctly."""<br>
@@ -96,7 +98,6 @@<br>
"""Test that int-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('int.cpp', set(['int']), dsym=False)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_int_type_with_dwarf(self):<br>
"""Test that int-type variable expressions are evaluated correctly."""<br>
@@ -114,7 +115,6 @@<br>
"""Test that 'unsigned int'-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('unsigned_int.cpp', set(['unsigned', 'int']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_int_type_with_dwarf(self):<br>
"""Test that 'unsigned int'-type variable expressions are evaluated correctly."""<br>
@@ -132,7 +132,6 @@<br>
"""Test that long-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('long.cpp', set(['long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_long_type_with_dwarf(self):<br>
"""Test that long-type variable expressions are evaluated correctly."""<br>
@@ -150,7 +149,6 @@<br>
"""Test that 'unsigned_long'-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('unsigned_long.cpp', set(['unsigned', 'long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_long_type_with_dwarf(self):<br>
"""Test that 'unsigned long'-type variable expressions are evaluated correctly."""<br>
@@ -171,7 +169,6 @@<br>
"""Test that 'long_long'-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('long_long.cpp', set(['long long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_long_long_type_with_dwarf(self):<br>
"""Test that 'long long'-type variable expressions are evaluated correctly."""<br>
@@ -189,7 +186,6 @@<br>
"""Test that 'unsigned_long_long'-type variables are displayed correctly from a block."""<br>
self.build_and_run_expr('unsigned_long_long.cpp', set(['unsigned', 'long long']), bc=True)<br>
<br>
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")<br>
@dwarf_test<br>
def test_unsigned_long_long_type_with_dwarf(self):<br>
"""Test that 'unsigned long long'-type variable expressions are evaluated correctly."""<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div>