If you're using SeekFromStart, why did you keep the lseek call?<div><br></div><div>Regards,</div><div><br clear="all">  Filipe<br><br>
<br><br><div class="gmail_quote">On Tue, Oct 30, 2012 at 4:55 AM, Carlo Kok <span dir="ltr"><<a href="mailto:ck@remobjects.com" target="_blank">ck@remobjects.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Author: carlokok<br>
Date: Tue Oct 30 06:55:43 2012<br>
New Revision: 167012<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=167012&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=167012&view=rev</a><br>
Log:<br>
Windows fix: "File" doesn't actually seek when reading, make it always run from the start of the file instead of the given offset.<br>
<br>
Modified:<br>
    lldb/branches/windows/source/Host/common/File.cpp<br>
<br>
Modified: lldb/branches/windows/source/Host/common/File.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/branches/windows/source/Host/common/File.cpp?rev=167012&r1=167011&r2=167012&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/branches/windows/source/Host/common/File.cpp?rev=167012&r1=167011&r2=167012&view=diff</a><br>


==============================================================================<br>
--- lldb/branches/windows/source/Host/common/File.cpp (original)<br>
+++ lldb/branches/windows/source/Host/common/File.cpp Tue Oct 30 06:55:43 2012<br>
@@ -557,6 +557,7 @@<br>
     return error;<br>
 #else<br>
     long cur = ::lseek(m_descriptor, 0, SEEK_CUR);<br>
+    SeekFromStart(offset);<br>
     Error error = Read(buf, num_bytes);<br>
     if (!error.Fail())<br>
         SeekFromStart(cur);<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div>