<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"><base href="x-msg://5418/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Your patch went in as r163332<div><br></div><div>Thanks :)</div><div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="orphans: 2; text-align: -webkit-auto; text-indent: 0px; widows: 2; -webkit-text-decorations-in-effect: none; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; color: rgb(0, 0, 0); "><i>Enrico Granata</i></div><div style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">✉ egranata@<font class="Apple-style-span" color="#ff230e"></font>.com</div><div>✆ (408) 972-7683</div></div></span></div></span></div></span></span>
</div>
<br><div><div>On Sep 5, 2012, at 6:15 PM, "Malea, Daniel" <<a href="mailto:daniel.malea@intel.com">daniel.malea@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div lang="EN-US" link="blue" vlink="purple" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div class="WordSection1" style="page: WordSection1; "><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Hi Enrico, please find the updated patch attached.<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">It is identical to the previous, except for PlatformRemoteiOS.cpp. It now uses the same approach as the other #ifdef block on line 125 of the same file.<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Thanks a bunch,<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Dan<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(181, 196, 223); padding: 3pt 0in 0in; "><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><b><span style="font-size: 10pt; font-family: Tahoma, sans-serif; ">From:</span></b><span style="font-size: 10pt; font-family: Tahoma, sans-serif; "><span class="Apple-converted-space"> </span>Enrico Granata [mailto:egranata@<a href="http://apple.com" style="color: purple; text-decoration: underline; ">apple.com</a>]<span class="Apple-converted-space"> </span><br><b>Sent:</b><span class="Apple-converted-space"> </span>Wednesday, September 05, 2012 8:44 PM<br><b>To:</b><span class="Apple-converted-space"> </span>Malea, Daniel<br><b>Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:lldb-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">lldb-commits@cs.uiuc.edu</a><br><b>Subject:</b><span class="Apple-converted-space"> </span>Re: [Lldb-commits] [PATCH] build fixes for Linux<o:p></o:p></span></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><o:p> </o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; ">If you have a better idea, feel free to submit a new patch with the better changes :-)<o:p></o:p></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><o:p> </o:p></div><div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><i><span style="font-size: 13.5pt; font-family: Helvetica, sans-serif; ">Enrico Granata</span></i><span style="font-size: 13.5pt; font-family: Helvetica, sans-serif; "><o:p></o:p></span></div></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 13.5pt; font-family: 'MS Gothic'; ">✉</span><span style="font-size: 13.5pt; font-family: Helvetica, sans-serif; "><span class="Apple-converted-space"> </span><a href="mailto:egranata@.com" style="color: purple; text-decoration: underline; ">egranata@.com</a><o:p></o:p></span></div></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 13.5pt; font-family: 'MS Gothic'; ">✆</span><span style="font-size: 13.5pt; font-family: Helvetica, sans-serif; "><span class="Apple-converted-space"> </span>(408) 972-7683<o:p></o:p></span></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><o:p> </o:p></div><div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; ">On Sep 5, 2012, at 4:31 PM, "Malea, Daniel" <<a href="mailto:daniel.malea@intel.com" style="color: purple; text-decoration: underline; ">daniel.malea@intel.com</a>> wrote:<o:p></o:p></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><br><br><o:p></o:p></div><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 12pt; font-family: 'Times New Roman', serif; ">Thanks for taking a look Enrico. The PlatformRemoteiOS.cpp change just matches the brace from line 100 when __APPLE__ is not defined. However, on a closer inspection, it may be best to have the entire "default:" case outside the ifdef...<br><br><br>Dan<br><br><br>On 2012-09-05, at 6:40 PM, "Enrico Granata" <<a href="mailto:egranata@apple.com" style="color: purple; text-decoration: underline; ">egranata@apple.com</a><<a href="mailto:egranata@apple.com" style="color: purple; text-decoration: underline; ">mailto:egranata@apple.com</a>>> wrote:<br><br>I am not sure about the PlatformRemoteiOS.cpp changes - but I have no objection to the other modifications brought in with this patch<br><br>Enrico Granata<br><span style="font-family: 'MS Mincho'; ">✉</span><span class="Apple-converted-space"> </span><a href="mailto:egranata@.com" style="color: purple; text-decoration: underline; ">egranata@.com</a><br><span style="font-family: 'MS Mincho'; ">✆</span><span class="Apple-converted-space"> </span>(408) 972-7683<br><br>On Sep 5, 2012, at 3:19 PM, "Malea, Daniel" <<a href="mailto:daniel.malea@intel.com" style="color: purple; text-decoration: underline; ">daniel.malea@intel.com</a><<a href="mailto:daniel.malea@intel.com" style="color: purple; text-decoration: underline; ">mailto:daniel.malea@intel.com</a>>> wrote:<br><br>Hi,<br><br>I noticed a few build problems on Linux introduced by recent commits. Please find the attached patch that addresses:<br>- missing include of stdint.h (required for int64_t)<br>- null return type in functions that must return SP<br>- off-by-one-line brace typo in PlatformRemoteiOS.cpp<br><br>With the patch applied (and the recently-comitted clang patch to enable the UTF functions) I am able to build trunk lldb on Linux :)<br><br>Cheers,<br>Dan<br><br>PS. git patch, so apply with -p1<br><br><lldb_incl_rettype_ios_buildfix.patch>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">lldb-commits@cs.uiuc.edu</a><<a href="mailto:lldb-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">mailto:lldb-commits@cs.uiuc.edu</a>><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" style="color: purple; text-decoration: underline; ">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><o:p></o:p></p></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><o:p> </o:p></div></div></div><span><lldb_incl_rettype_ios_buildfix_v2.patch></span></div></blockquote></div><br></div></body></html>