<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Seems to make sense. Thanks for pointing it out:<div><br></div><div><div>Sending source/Host/common/Host.cpp</div><div>Sending source/Host/macosx/Host.mm</div><div>Transmitting file data ..</div><div>Committed revision 155023.</div></div><div><br><div apple-content-edited="true">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="orphans: 2; text-align: -webkit-auto; text-indent: 0px; widows: 2; -webkit-text-decorations-in-effect: none; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; color: rgb(0, 0, 0); "><i>Enrico Granata</i></div><div style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">✉ egranata@<font class="Apple-style-span" color="#ff230e"></font>.com</div><div>✆ (four oh eight) 862-7683</div></div></span></div></span></div></span></div></span></div>
</div>
<br><div><div>On Apr 18, 2012, at 10:34 AM, Viktor Kutuzov wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi Enrico,<br><br>I would like to propose to move this code into the common Host.cpp (source/Host/Host/common/Host.cpp). Your changes do not contain any platform dependent stuff and it should work on any platform there.<br>What do you think?<br><br>Thanks.<br>Viktor.<br><br>PS. exit_code type => uint32_t<br><br>-----Original Message-----<br>From: <a href="mailto:lldb-commits-bounces@cs.uiuc.edu">lldb-commits-bounces@cs.uiuc.edu</a> [mailto:lldb-commits-bounces@cs.uiuc.edu] On Behalf Of Enrico Granata<br>Sent: Tuesday, April 17, 2012 7:03 PM<br>To: <a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>Subject: [Lldb-commits] [lldb] r154977 - /lldb/branches/lldb-platform-work/source/Host/macosx/Host.mm<br><br>Author: enrico<br>Date: Tue Apr 17 21:02:59 2012<br>New Revision: 154977<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=154977&view=rev">http://llvm.org/viewvc/llvm-project?rev=154977&view=rev</a><br>Log:<br>Using the new enhanced RunShellCommand() to implement Host::RunProgramAndGetExitCode() - this centralizes the code we use to launch a process across the board. next step is to enable the remote platforms to launch a process via the RunShellCommand() and obtain all the information that that call is able to provide<br><br>Modified:<br> lldb/branches/lldb-platform-work/source/Host/macosx/Host.mm<br><br>Modified: lldb/branches/lldb-platform-work/source/Host/macosx/Host.mm<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/branches/lldb-platform-work/source/Host/macosx/Host.mm?rev=154977&r1=154976&r2=154977&view=diff">http://llvm.org/viewvc/llvm-project/lldb/branches/lldb-platform-work/source/Host/macosx/Host.mm?rev=154977&r1=154976&r2=154977&view=diff</a><br>==============================================================================<br>--- lldb/branches/lldb-platform-work/source/Host/macosx/Host.mm (original)<br>+++ lldb/branches/lldb-platform-work/source/Host/macosx/Host.mm Tue Apr <br>+++ 17 21:02:59 2012<br>@@ -1847,7 +1847,11 @@<br> uint32_t<br> Host::RunProgramAndGetExitCode (const char *cmd_line) {<br>- return ::system(cmd_line);<br>+ int exit_code;<br>+ Error err(RunShellCommand(cmd_line, NULL, &exit_code, NULL, NULL, 10));<br>+ if (err.Fail())<br>+ return UINT32_MAX;<br>+ return exit_code;<br> }<br><br> uint32_t<br><br><br>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits<br></div></blockquote></div><br></div></body></html>