<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<tt>Note,<br>
The line numbering in this patch depends on the previous patch I
sent to the list regarding updating LLDB's usage of Clang/LLVM
APIs. See <a
href="http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20110711/003313.html">http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20110711/003313.html</a>.
Sorry about that.<br>
-Matt<br>
<br>
On 07/15/2011 03:26 PM, Matt Johnson wrote:</tt>
<blockquote cite="mid:4E20A28C.9070402@crhc.illinois.edu"
type="cite"><tt>Hi all,
<br>
This is the beginning of a cleanup effort to reduce the (vast)
number of (mostly benign) warnings when compiling LLDB HEAD
under G++ 4.5.2 on Ubuntu 11.04. Getting these warnings out of
the way makes it much easier to spot more important warnings, if
nothing else. The fixes here can be categorized as follows:
<br>
<br>
* Use of a signed type as a for loop induction variable, when
the loop bound is an unsigned type
</tt>
<tt><br>
* Assigning NULL (a pointer constant) to non-pointer types
(e.g., uint32_t, addr_t)
<br>
* Declaring class members in one order, and including them in
constructor initializer lists in a different order
<br>
<br>
There are many more of the above warnings that I haven't gotten
to yet, as well as things like the following:
</tt>
<tt><br>
* Python docstrings in e.g. SBTarget.h use a nonstandard gcc
preprocessor extension that allows multi-line string literals.
<br>
- This causes *tons* of warnings (one per line of the literal,
per inclusion of the relevant header). e.g.:
<br>
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:23:1:
warning: missing terminating " character
</tt>
<tt><br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:48:1:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:91:27:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:164:5:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:180:27:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:216:5:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:224:27:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:245:5:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:253:27:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:277:5:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:286:27:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:310:5:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:334:27:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:361:5:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:370:27:
warning: missing terminating " character
<br>
/media/d2/llvm/tools/lldb/source/Target/../../include/lldb/API/SBTarget.h:386:5:
warning: missing terminating " character
<br>
<br>
- These literals should be formed like:
</tt>
<tt><br>
<br>
#ifdef SWIG
</tt>
<tt><br>
%feature("docstring",
<br>
"Represents the target program running under the debugger.\n"
<br>
"\n"
<br>
"SBTarget supports module and breakpoint iterations. For
example,\n"
<br>
...
<br>
<br>
- instead of:
</tt>
<tt><br>
<br>
%feature("docstring",
</tt>
<tt><br>
"Represents the target program running under the debugger.
<br>
<br>
SBTarget supports module and breakpoint iterations. For example,
</tt>
<tt><br>
...
<br>
<br>
<br>
* Use of (deprecated) <ext/hash_map> instead of
<unordered_map>
</tt>
<tt><br>
* Not handling some enum values in a switch statement. e.g.,
"ClangASTType.cpp:283:12: warning: enumeration value
‘UnaryTransform’ not handled in switch"
<br>
* Defining static helper functions that are never used. e.g.,
"RegisterContextLinux_x86_64.cpp:408:17: warning: ‘unsigned int
GetRegSize(unsigned int)’ defined but not used"
<br>
<br>
Comments welcome.
</tt>
<tt><br>
Best,
<br>
Matt
<br>
</tt>
<pre wrap=""><tt>
</tt><fieldset class="mimeAttachmentHeader"></fieldset><tt>
_______________________________________________
lldb-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a>
</tt></pre>
</blockquote>
</body>
</html>