<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 11, 2010, at 3:56 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On Jun 9, 2010, at 12:36 PM, Greg Clayton wrote:<br><br><blockquote type="cite">Author: gclayton<br></blockquote><blockquote type="cite">Date: Wed Jun 9 14:36:54 2010<br></blockquote><blockquote type="cite">New Revision: 105748<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=105748&view=rev">http://llvm.org/viewvc/llvm-project?rev=105748&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">For header includes we are currently trying to adopt some aspects of the <br></blockquote><blockquote type="cite">Google C++ coding guidelines where includes are done as:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">1 - the header file for the current source file<br></blockquote><blockquote type="cite">2 - C includes<br></blockquote><blockquote type="cite">3 - C++ includes<br></blockquote><blockquote type="cite">4 - external project includes<br></blockquote><blockquote type="cite">5 - current project includes<br></blockquote><br>Hey Greg,<br><br>Any objection to migrating to the llvm style?<br><a href="http://llvm.org/docs/CodingStandards.html#scf_includes">http://llvm.org/docs/CodingStandards.html#scf_includes</a><br>http://llvm.org/docs/CodingStandards.html#hl_dontinclude<br><br>Also, in C++ code, it is generally better to #include <cstdio> instead of <stdio.h>, because it is technically more portable. Any objection to eventually migrating this way?<br></div></blockquote><div><br></div>That sounds fine. We want to be good LLVM citizens!</div><div><br></div><div>Greg</div><div><br><blockquote type="cite"><div><blockquote type="cite"><font class="Apple-style-span" color="#144FAE"><br></font></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Modified:<br></blockquote><blockquote type="cite"> lldb/trunk/source/Core/UUID.cpp<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Modified: lldb/trunk/source/Core/UUID.cpp<br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/UUID.cpp?rev=105748&r1=105747&r2=105748&view=diff">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/UUID.cpp?rev=105748&r1=105747&r2=105748&view=diff</a><br></blockquote><blockquote type="cite">==============================================================================<br></blockquote><blockquote type="cite">--- lldb/trunk/source/Core/UUID.cpp (original)<br></blockquote><blockquote type="cite">+++ lldb/trunk/source/Core/UUID.cpp Wed Jun 9 14:36:54 2010<br></blockquote><blockquote type="cite">@@ -9,13 +9,14 @@<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">#include "lldb/Core/UUID.h"<br></blockquote><blockquote type="cite">// C Includes<br></blockquote><blockquote type="cite">+#include <string.h><br></blockquote><blockquote type="cite">+#include <stdio.h><br></blockquote><blockquote type="cite">+#include <ctype.h><br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">// C++ Includes<br></blockquote><blockquote type="cite">// Other libraries and framework includes<br></blockquote><blockquote type="cite">// Project includes<br></blockquote><blockquote type="cite">#include "lldb/Core/Stream.h"<br></blockquote><blockquote type="cite">-#include <string.h><br></blockquote><blockquote type="cite">-#include <stdio.h><br></blockquote><blockquote type="cite">-#include <ctype.h><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">using namespace lldb_private;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">lldb-commits mailing list<br></blockquote><blockquote type="cite"><a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br></blockquote><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br></blockquote><br></div></blockquote></div><br></body></html>