<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Eli,<br><br>I'm very glad you are so interested in LLDB and taking such an active part to help us in our<br>development. About removing dead code: I don't think this particular case is a problem, but LLDB is<br>still in fairly early development. Sometimes there is dead code that really is dead and probably<br>should be removed, but other times there might be seemingly dead code that was really put there<br>as a reminder of something to write or hook up in the future. Please don't remove seemingly dead<div>code for now. Thanks!<br><br>-- Caroline Tice<br><a href="mailto:ctice@apple.com">ctice@apple.com</a><br><div><div>On Jun 9, 2010, at 3:59 AM, Eli Friedman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Author: efriedma<br>Date: Wed Jun 9 05:59:23 2010<br>New Revision: 105724<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=105724&view=rev">http://llvm.org/viewvc/llvm-project?rev=105724&view=rev</a><br>Log:<br>Remove unused class.<br><br><br>Modified:<br> lldb/trunk/source/Core/Args.cpp<br><br>Modified: lldb/trunk/source/Core/Args.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Args.cpp?rev=105724&r1=105723&r2=105724&view=diff">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Args.cpp?rev=105724&r1=105723&r2=105724&view=diff</a><br>==============================================================================<br>--- lldb/trunk/source/Core/Args.cpp (original)<br>+++ lldb/trunk/source/Core/Args.cpp Wed Jun 9 05:59:23 2010<br>@@ -9,8 +9,7 @@<br><br> // C Includes<br> #include <getopt.h><br>-#include <histedit.h><br>-<br>+#include <cstdlib><br> // C++ Includes<br> // Other libraries and framework includes<br> // Project includes<br>@@ -21,93 +20,6 @@<br> #include "lldb/Core/Options.h"<br> #include "lldb/Interpreter/CommandReturnObject.h"<br><br>-namespace lldb_private {<br>-<br>-class Tokenizer<br>-{<br>-public:<br>- Tokenizer (const char *separator_chars = NULL) :<br>- m_tokenizer(NULL)<br>- {<br>- m_tokenizer = ::tok_init (separator_chars);<br>- }<br>-<br>- ~Tokenizer ()<br>- {<br>- if (m_tokenizer)<br>- {<br>- ::tok_end (m_tokenizer);<br>- m_tokenizer = NULL;<br>- }<br>- }<br>-<br>- void<br>- Reset ()<br>- {<br>- assert (m_tokenizer);<br>- ::tok_reset (m_tokenizer);<br>- }<br>-<br>- int<br>- TokenizeLineInfo (const ::LineInfo *line_info)<br>- {<br>- assert (m_tokenizer);<br>- return ::tok_line (m_tokenizer,<br>- line_info,<br>- &m_argc,<br>- &m_argv,<br>- &m_cursor_arg_index,<br>- &m_cursor_arg_offset);<br>- }<br>-<br>- int<br>- TokenizeCString (const char *cstr)<br>- {<br>- assert (m_tokenizer);<br>- m_cursor_arg_index = -1;<br>- m_cursor_arg_offset = -1;<br>- return ::tok_str (m_tokenizer,<br>- cstr,<br>- &m_argc,<br>- &m_argv);<br>- }<br>-<br>-<br>- int<br>- GetArgCount () const<br>- {<br>- return m_argc;<br>- }<br>-<br>- const char **<br>- GetArgVector () const<br>- {<br>- return m_argv;<br>- }<br>-<br>- int<br>- GetCursoreArgIndex () const<br>- {<br>- return m_cursor_arg_index;<br>- }<br>-<br>- int<br>- GetCursoreArgOffset () const<br>- {<br>- return m_cursor_arg_offset;<br>- }<br>-<br>-<br>-protected:<br>- struct tokenizer* m_tokenizer;<br>- const char **m_argv;<br>- int m_argc;<br>- int m_cursor_arg_index;<br>- int m_cursor_arg_offset;<br>-};<br>-<br>-} // namespace lldb_private<br>-<br> using namespace lldb;<br> using namespace lldb_private;<br><br><br><br>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits<br></div></blockquote></div><br></div></body></html>