[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 26 13:25:11 PDT 2024


================
@@ -10,6 +10,7 @@ config.llvm_build_mode = lit_config.substitute("@LLVM_BUILD_MODE@")
 config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
 config.lldb_obj_root = "@LLDB_BINARY_DIR@"
 config.lldb_src_root = "@LLDB_SOURCE_DIR@"
+config.lldb_built_include_dir = lit_config.substitute("@LLDB_BINARY_DIR@/include")
----------------
JDevlieghere wrote:

If this is always `@LLDB_BINARY_DIR@/include`, why not use 

```
config.lldb_built_include_dir = os.path.join(config.lldb_obj_root. 'include')
```

or even better: don't create a new variable at all and have dotest derive it from `config.lldb_obj_root`? 

https://github.com/llvm/llvm-project/pull/89981


More information about the lldb-commits mailing list