[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

Alastair Houghton via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 26 03:24:52 PDT 2024


================
@@ -2067,10 +2110,8 @@ unsigned ObjectFileELF::ParseSymbols(Symtab *symtab, user_id_t start_id,
   SectionList *module_section_list =
       module_sp ? module_sp->GetSectionList() : nullptr;
 
-  // Local cache to avoid doing a FindSectionByName for each symbol. The "const
-  // char*" key must came from a ConstString object so they can be compared by
-  // pointer
-  std::unordered_map<const char *, lldb::SectionSP> section_name_to_section;
+  // Cache the section mapping
----------------
al45tair wrote:

I'll improve the comment.

https://github.com/llvm/llvm-project/pull/90099


More information about the lldb-commits mailing list