[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

Anthony Ha via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 15 16:46:30 PDT 2024


================
@@ -1184,7 +1184,7 @@ bool Platform::IsCompatibleArchitecture(const ArchSpec &arch,
 Status Platform::PutFile(const FileSpec &source, const FileSpec &destination,
                          uint32_t uid, uint32_t gid) {
   Log *log = GetLog(LLDBLog::Platform);
-  LLDB_LOGF(log, "[PutFile] Using block by block transfer....\n");
+  LLDB_LOGF(log, "[PutFile] Using block by block transfer....");
----------------
Awfa wrote:

When testing this change, and using `log enable lldb platform` to read the logs, I just noticed this had a `\n` and removed it since `LLDB_LOGF` already adds a new line, and it didn't seem like most other logs had `\n`.

Is this bad to have in the patch?

https://github.com/llvm/llvm-project/pull/88812


More information about the lldb-commits mailing list