[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)
Alex Langford via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 15 16:28:33 PDT 2024
================
@@ -684,6 +684,15 @@ Status PlatformRemoteGDBServer::RunShellCommand(
signo_ptr, command_output, timeout);
}
+bool PlatformRemoteGDBServer::CalculateMD5(const FileSpec &file_spec,
+ uint64_t &low, uint64_t &high) {
+ if (IsConnected()) {
+ // Note that high/low are switched in the gdb remote communication client
----------------
bulbazord wrote:
It's good that you have a comment for this because it "feels" wrong. But why are `high/low` swapped in the gdb remote communication client in the first place? Is that intentional or is this working around a bug?
https://github.com/llvm/llvm-project/pull/88812
More information about the lldb-commits
mailing list