[Lldb-commits] [lldb] [lldb][FreeBSD] Remove corefile test xfails (PR #84022)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 5 06:43:59 PST 2024


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/84022

Fixes #48759

As stated on the issue this was fixed by a change in FreeBSD 13, and I've confirmed that it passes on 14 as well.

>From e07cfd18f760b08fb049d556f5115480fb25322d Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Tue, 5 Mar 2024 14:42:13 +0000
Subject: [PATCH] [lldb][FreeBSD] Remove corefile test xfails

Fixes #48759

As stated on the issue this was fixed by a change in FreeBSD 13,
and I've confirmed that it passes on 14 as well.
---
 .../functionalities/postmortem/elf-core/TestLinuxCore.py  | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py b/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
index 7ec5e0d7c8309b..8ec0cbdd0fdd1f 100644
--- a/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
+++ b/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
@@ -292,9 +292,7 @@ def test_aarch64_pac(self):
         self.dbg.DeleteTarget(target)
 
     @skipIfLLVMTargetMissing("AArch64")
-    @expectedFailureAll(
-        archs=["aarch64"], oslist=["freebsd"], bugnumber="llvm.org/pr49415"
-    )
+    # This test fails on FreeBSD 12 and earlier, see llvm.org/pr49415 for details.
     def test_aarch64_regs(self):
         # check 64 bit ARM core files
         target = self.dbg.CreateTarget(None)
@@ -377,9 +375,7 @@ def test_aarch64_regs(self):
         self.expect("register read --all")
 
     @skipIfLLVMTargetMissing("AArch64")
-    @expectedFailureAll(
-        archs=["aarch64"], oslist=["freebsd"], bugnumber="llvm.org/pr49415"
-    )
+    # This test fails on FreeBSD 12 and earlier, see llvm.org/pr49415 for details.
     def test_aarch64_sve_regs_fpsimd(self):
         # check 64 bit ARM core files
         target = self.dbg.CreateTarget(None)



More information about the lldb-commits mailing list