[Lldb-commits] [lldb] [lldb][X86] Fix setting target features in ClangExpressionParser (PR #82364)

[Daniil Kovalev via lldb-commits]

kovdan01 wrote:

> Would this change be observable by a test?

@adrian-prantl Theoretically, it should be: in `ClangExpressionParser::ClangExpressionParser`, we try to hardcode sse and sse2 for both x86 and x86_64, while in `X86TargetInfo::initFeatureMap`, sse2 (implying sse) is only hardcoded for x86_64. So, for x86 the observable behavior should change.

Unfortunately, I'm not sure where and how this could be tested. I suppose the proper place for such a test is somewhere in lldb/unittests/Expression, but I don't see existing tests which check similar stuff. Please let me know if I miss something. 

@Michael137 would be glad to see your thoughts on this.

https://github.com/llvm/llvm-project/pull/82364