[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

Chelsea Cassanova via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 28 10:22:21 PST 2024


================
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() {
   return *g_progress_manager;
 }
 
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
----------------
chelcassanova wrote:

Yeah, the title is used for map queries but the data itself isn't stored in the map, it's passed on to `ProgressManager::ReportProgress`.  If we change it to a const ref (`const Progress::ProgressData& progress_data`) here then we probably also want to do this for `Decrement` since it uses the map in a similar way.

https://github.com/llvm/llvm-project/pull/83069


More information about the lldb-commits mailing list