[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

Georgios Pinitas via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 27 16:34:56 PST 2024


================
@@ -227,7 +265,7 @@ class ThreadPool {
 class ThreadPoolTaskGroup {
----------------
GeorgeARM wrote:

Btw, I still think that passing a `ThreadPoolTaskGroup` for the sole purpose of a uid is a bit brittle as you bind the interface with this construct but internally to the `ThreadPool` no member function of it is called?!
We could change for example this with a `std::string` with probably minimal changes to any call site.
Apologies if that is not right but I am not familiar with the code.

https://github.com/llvm/llvm-project/pull/82094


More information about the lldb-commits mailing list