[Lldb-commits] [lldb] [llvm] [lldb-dap] Add support for data breakpoint. (PR #81541)

[via lldb-commits]

Prabhuk wrote:

We (Fuchsia clang toolchain team) are facing a LLDB test failure in our ARM64 Clang toolchain builders and I suspect this change is causing the failure.

Build link: https://ci.chromium.org/raw/build/logs.chromium.org/fuchsia/led/prabhukr_google.com/04517f65babfe0d4ee60f891a290183f9cfe5121932ac926d829bf2f3aee99ea/+/build.proto?server=chromium-swarm.appspot.com

Log: https://logs.chromium.org/logs/fuchsia/led/prabhukr_google.com/04517f65babfe0d4ee60f891a290183f9cfe5121932ac926d829bf2f3aee99ea/+/u/lldb/test/stdout


```
--
Command Output (stderr):
--
FAIL: LLDB (/b/s/w/ir/x/w/llvm_build/bin/clang-aarch64) :: test_expression (TestDAP_setDataBreakpoints.TestDAP_setDataBreakpoints)
FAIL: LLDB (/b/s/w/ir/x/w/llvm_build/bin/clang-aarch64) :: test_functionality (TestDAP_setDataBreakpoints.TestDAP_setDataBreakpoints)
======================================================================
FAIL: test_expression (TestDAP_setDataBreakpoints.TestDAP_setDataBreakpoints)
   Tests setting data breakpoints on expression.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/tools/lldb-dap/databreakpoint/TestDAP_setDataBreakpoints.py", line 52, in test_expression
    self.assertEquals(i_val, "2")
AssertionError: '-2320' != '2'
- -2320+ 2
Config=aarch64-/b/s/w/ir/x/w/llvm_build/bin/clang
======================================================================
FAIL: test_functionality (TestDAP_setDataBreakpoints.TestDAP_setDataBreakpoints)
   Tests setting data breakpoints on variable.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/tools/lldb-dap/databreakpoint/TestDAP_setDataBreakpoints.py", line 93, in test_functionality
    self.assertEquals(i_val, "2")
AssertionError: '-2320' != '2'
- -2320+ 2
Config=aarch64-/b/s/w/ir/x/w/llvm_build/bin/clang
----------------------------------------------------------------------
Ran 2 tests in 2.339s

RESULT: FAILED (0 passes, 2 failures, 0 errors, 0 skipped, 0 expected failures, 0 unexpected successes)

--
```

I am building current ToT without this commit to verify if this failure goes away. 

https://github.com/llvm/llvm-project/pull/81541