[Lldb-commits] [lldb] [lldb] Add QSupported key to report watchpoint types supported (PR #80376)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 2 06:15:24 PST 2024


DavidSpickett wrote:

Just to record that I thought about it, I agree with not trying to make the names architecture neutral.

For example one might say that because range watchpoints on mips and aarch64 have overlapping functionality (no pun intended) that we could report that we have "range" as a type for either of them. This leads to a situation where the functionality that doesn't overlap becomes much harder to handle and detect.

So I agree with `aarch64-mask` instead of simply `mask`, as an example.

If we later want to (and kinda already do) group these by general functionality, we can do that in lldb in the algorithms you added for working out the watchpoint resources.

(and sod's law, someone will propose to add `aarch64-bas-but-this-one-thing-is-different` to the architecture one of these days :) )

https://github.com/llvm/llvm-project/pull/80376


More information about the lldb-commits mailing list