[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

[via lldb-commits]

jimingham wrote:

That one's odd, it almost belongs in Platform, after all, there's no guarantee that "assert" is implemented by pthread functions at all.  It just happens to be on Unix systems.

Jim


> On Feb 1, 2024, at 7:32 PM, Jim Ingham ***@***.***> wrote:
> 
> There IS an AssertFrameRecogizer that does just what you suggest, but it is in source/Target.  These really should go somewhere else, however, Target is too general for anything but the base recognizer class.
> 
> Jim
> 
> 
>> On Feb 1, 2024, at 6:43 PM, Greg Clayton ***@***.***> wrote:
>> 
>> 
>> This almost seems like a compiler runtime plug-in, but C language would be fine. I would rather see this in plug-in somewhere if possible. It might be nice to have these plug-ins register one or more frame regular expression values that point to the plug-in so we can add more things. It would be nice to also add support for C assert() calls that would unwind the stack to the offinding assert function above the 3 or 4 pthread functions that occur when an assertion is hit
>> 
>> —
>> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/80368#issuecomment-1922690954>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW3VRHN3DNFRZYNLY2TYRRHGZAVCNFSM6AAAAABCV3DNHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRSGY4TAOJVGQ>.
>> You are receiving this because you are on a team that was mentioned.
>> 
> 



https://github.com/llvm/llvm-project/pull/80368