[Lldb-commits] [lldb] Add commands frequency to statistics dump (PR #80375)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 1f3c30911cc5eee4b42bdc9c6358c689b2f2f223...59e1499ec0afebb533c4952f079278341b957241 lldb/test/API/commands/statistics/basic/TestStats.py lldb/test/API/functionalities/stats_api/TestStatisticsAPI.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- commands/statistics/basic/TestStats.py	2024-02-02 02:07:51.000000 +0000
+++ commands/statistics/basic/TestStats.py	2024-02-02 02:10:41.509153 +0000
@@ -360,20 +360,20 @@
         self.assertNotEqual(exe_module, None)
         self.verify_keys(exe_module, 'module dict for "%s"' % (exe), module_keys)
 
     def test_commands(self):
         """
-            Test "statistics dump" and the command information.
+        Test "statistics dump" and the command information.
         """
         self.build()
         exe = self.getBuildArtifact("a.out")
         target = self.createTestTarget(file_path=exe)
 
         interp = self.dbg.GetCommandInterpreter()
         result = lldb.SBCommandReturnObject()
-        interp.HandleCommand('target list', result)
-        interp.HandleCommand('target list', result)
+        interp.HandleCommand("target list", result)
+        interp.HandleCommand("target list", result)
 
         debug_stats = self.get_stats()
 
         command_stats = self.get_command_stats(debug_stats)
         self.assertNotEqual(command_stats, None)
--- functionalities/stats_api/TestStatisticsAPI.py	2024-02-02 02:07:51.000000 +0000
+++ functionalities/stats_api/TestStatisticsAPI.py	2024-02-02 02:10:41.562490 +0000
@@ -10,11 +10,11 @@
 class TestStatsAPI(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
 
     def test_stats_api(self):
         """
-            Test SBTarget::GetStatistics() API.
+        Test SBTarget::GetStatistics() API.
         """
         self.build()
         exe = self.getBuildArtifact("a.out")
         target = self.dbg.CreateTarget(exe)
 
@@ -73,26 +73,26 @@
             True,
             'Make sure the "failures" key in in "frameVariable" dictionary"',
         )
 
     def test_command_stats_api(self):
-            """
-                Test GetCommandInterpreter::GetStatistics() API.
-            """
-            self.build()
-            exe = self.getBuildArtifact("a.out")
-            lldbutil.run_to_name_breakpoint(self, 'main')
+        """
+        Test GetCommandInterpreter::GetStatistics() API.
+        """
+        self.build()
+        exe = self.getBuildArtifact("a.out")
+        lldbutil.run_to_name_breakpoint(self, "main")
 
-            interp = self.dbg.GetCommandInterpreter()
-            result = lldb.SBCommandReturnObject()
-            interp.HandleCommand('bt', result)
+        interp = self.dbg.GetCommandInterpreter()
+        result = lldb.SBCommandReturnObject()
+        interp.HandleCommand("bt", result)
 
-            stream = lldb.SBStream()
-            res = interp.GetStatistics().GetAsJSON(stream)
-            command_stats = json.loads(stream.GetData())
+        stream = lldb.SBStream()
+        res = interp.GetStatistics().GetAsJSON(stream)
+        command_stats = json.loads(stream.GetData())
 
-            # Verify bt command is correctly parsed into final form.
-            self.assertEqual(command_stats["thread backtrace"], 1)
-            # Verify original raw command is not duplicatedly captured.
-            self.assertNotIn('bt', command_stats)
-            # Verify bt's regex command is not duplicatedly captured.
-            self.assertNotIn('_regexp-bt', command_stats)
+        # Verify bt command is correctly parsed into final form.
+        self.assertEqual(command_stats["thread backtrace"], 1)
+        # Verify original raw command is not duplicatedly captured.
+        self.assertNotIn("bt", command_stats)
+        # Verify bt's regex command is not duplicatedly captured.
+        self.assertNotIn("_regexp-bt", command_stats)

``````````

</details>


https://github.com/llvm/llvm-project/pull/80375