[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 1 09:37:17 PST 2024


================
@@ -1305,6 +1305,14 @@ enum CompletionType {
   eTerminatorCompletion = (1ul << 27)
 };
 
+/// Specifies if children need to be re-computed
+/// after a call to \ref SyntheticChildrenFrontEnd::Update.
+enum class ChildCacheState {
+  eDynamic = 0, ///< Children need to be recomputed dynamically.
+  eConstant =
+      1, ///< Children will never change and don't need to be recomputed.
----------------
kastiglione wrote:

Is `eConstant` really constant? In other words, if `Update()` returns `eConstant` the first time, will it always return `eConstant` every other invocation? If not, then I would like to see a different name/names. Do you find issue with the verb approach I suggested?

https://github.com/llvm/llvm-project/pull/80167


More information about the lldb-commits mailing list