[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 29 22:16:55 PST 2024


================
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData {
   GetAsStructuredData(const Event *event_ptr);
 
   uint64_t GetID() const { return m_id; }
-  bool IsFinite() const { return m_total != UINT64_MAX; }
+  bool IsFinite() const { return m_total != 1; }
----------------
clayborg wrote:

I realize I had suggested using the magic number 1 in previous reviews...

https://github.com/llvm/llvm-project/pull/79912


More information about the lldb-commits mailing list