[Lldb-commits] [lldb] [lldb][NFCI] Remove unused method BreakpointIDList::AddBreakpointID(const char *) (PR #79189)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 23 10:36:53 PST 2024


https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/79189

This overload is completely unused.

>From c04b7a72444b167ab59604a7dce84bfadad0d45e Mon Sep 17 00:00:00 2001
From: Alex Langford <alangford at apple.com>
Date: Tue, 23 Jan 2024 10:33:07 -0800
Subject: [PATCH] [lldb][NFCI] Remove unused method
 BreakpointIDList::AddBreakpointID(const char *)

This overload is completely unused.
---
 lldb/include/lldb/Breakpoint/BreakpointIDList.h | 2 --
 lldb/source/Breakpoint/BreakpointIDList.cpp     | 9 ---------
 2 files changed, 11 deletions(-)

diff --git a/lldb/include/lldb/Breakpoint/BreakpointIDList.h b/lldb/include/lldb/Breakpoint/BreakpointIDList.h
index 3cda1860dc16721..6c57d9bc507952f 100644
--- a/lldb/include/lldb/Breakpoint/BreakpointIDList.h
+++ b/lldb/include/lldb/Breakpoint/BreakpointIDList.h
@@ -42,8 +42,6 @@ class BreakpointIDList {
 
   bool AddBreakpointID(BreakpointID bp_id);
 
-  bool AddBreakpointID(const char *bp_id);
-
   // TODO: This should take a const BreakpointID.
   bool FindBreakpointID(BreakpointID &bp_id, size_t *position) const;
 
diff --git a/lldb/source/Breakpoint/BreakpointIDList.cpp b/lldb/source/Breakpoint/BreakpointIDList.cpp
index 51185c30dabad8c..5ab2c9a8dc3865b 100644
--- a/lldb/source/Breakpoint/BreakpointIDList.cpp
+++ b/lldb/source/Breakpoint/BreakpointIDList.cpp
@@ -48,15 +48,6 @@ bool BreakpointIDList::AddBreakpointID(BreakpointID bp_id) {
                // return true.
 }
 
-bool BreakpointIDList::AddBreakpointID(const char *bp_id_str) {
-  auto bp_id = BreakpointID::ParseCanonicalReference(bp_id_str);
-  if (!bp_id)
-    return false;
-
-  m_breakpoint_ids.push_back(*bp_id);
-  return true;
-}
-
 bool BreakpointIDList::FindBreakpointID(BreakpointID &bp_id,
                                         size_t *position) const {
   for (size_t i = 0; i < m_breakpoint_ids.size(); ++i) {



More information about the lldb-commits mailing list