[Lldb-commits] [lldb] [libcxx] [lld] [llvm] [compiler-rt] [lld-macho] Find objects in library search path (PR #78628)

via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 18 17:11:26 PST 2024


================
@@ -95,11 +95,16 @@ static std::optional<StringRef> findLibrary(StringRef name) {
               findPathCombination("lib" + name, config->librarySearchPaths,
                                   {".tbd", ".dylib", ".so"}))
         return path;
-      return findPathCombination("lib" + name, config->librarySearchPaths,
-                                 {".a"});
+      else if (std::optional<StringRef> path = findPathCombination(
+                   "lib" + name, config->librarySearchPaths, {".a"}))
+        return path;
+      return findPathCombination(name, config->librarySearchPaths, {""});
----------------
OldWorldOrdr wrote:

are you suggesting the code be
```c++
      return findPathCombination("lib" + name, config->librarySearchPaths,
                                 {".a", ""});
```
Won't that look for `libcrt1.o` instead of `crt1.o`?

https://github.com/llvm/llvm-project/pull/78628


More information about the lldb-commits mailing list