[Lldb-commits] [llvm] [lldb] Added settings for DEBUGINFOD cache location and timeout (PR #78605)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 18 11:21:25 PST 2024


================
@@ -54,6 +55,34 @@ class PluginProperties : public Properties {
     return urls;
   }
 
+  llvm::Expected<llvm::StringRef> GetCachePath() {
----------------
JDevlieghere wrote:

Is it always safe to return a StringRef here? It looks fine at first sight, but this code also doesn't look particularly hot, so playing it safe and returning a `std::string` avoids having to reason about the string's lifetime.

https://github.com/llvm/llvm-project/pull/78605


More information about the lldb-commits mailing list