[Lldb-commits] [clang] [clang-tools-extra] [libc] [llvm] [libcxxabi] [libcxx] [lld] [flang] [libunwind] [lldb] [compiler-rt] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

John McCall via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 18 11:00:29 PST 2024


rjmccall wrote:

> > This is unrelated, but I wonder if we should proactively outline this sequence; it's quite long.
> 
> Not sure what you mean.

I mean that we could lazily emit a helper function like `__clang_smiths_division_double` and call it instead of emitting like twenty instructions inline.

To be clear, I'm not suggesting you need to do this, and certainly not in this patch.

https://github.com/llvm/llvm-project/pull/78330


More information about the lldb-commits mailing list