[Lldb-commits] [lldb] [lldb][DWARFUnit] Implement PeekDIEName query (PR #78486)

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 17 13:03:54 PST 2024


felipepiovezan wrote:

Added tests for AT_specification and AT_abstract origin.

@clayborg I didn't change the implementation because IIUC the "parsed DIE" is merely a structure with computed parent/child/sibling relationship, we don't build any data structures for the attributes themselves. 

If we were to go through the parsed DIE (i.e. `DWARFDIE` instead of `DIERef`), the implementation will still boil down to the same thing, so we would be adding one more code path to `PeekDIEName` without any benefits. Does that make sense?

https://github.com/llvm/llvm-project/pull/78486


More information about the lldb-commits mailing list