[Lldb-commits] [lldb] 14268ad - [lldb] Skip part of TestDataFormatterAdv (#72233)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 15 04:52:37 PST 2024


Author: Pavel Labath
Date: 2024-01-15T12:49:24Z
New Revision: 14268ad2a2ea0b3bbe6b767d67ace1d0ae992a6d

URL: https://github.com/llvm/llvm-project/commit/14268ad2a2ea0b3bbe6b767d67ace1d0ae992a6d
DIFF: https://github.com/llvm/llvm-project/commit/14268ad2a2ea0b3bbe6b767d67ace1d0ae992a6d.diff

LOG: [lldb] Skip part of TestDataFormatterAdv (#72233)

libstdc++ data formatter simply forwards to the `const char *` formatter
-- which means it suffers from the same problem/bug as that one.

Added: 
    

Modified: 
    lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py b/lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py
index c275904eaf2014..d296e60d6e6e99 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py
@@ -6,6 +6,7 @@
 import lldb
 from lldbsuite.test.lldbtest import *
 import lldbsuite.test.lldbutil as lldbutil
+import re
 
 
 class AdvDataFormatterTestCase(TestBase):
@@ -298,7 +299,11 @@ def cleanup():
         self.runCmd("settings set target.max-string-summary-length 5")
         some_string = self.frame().FindVariable("some_string")
         some_string_summary = some_string.GetSummary()
-        self.assertEqual(some_string_summary, '"01234"...')
+        if (re.match(r"^std::__\w+::", some_string.GetTypeName())):
+          self.assertEqual(some_string_summary, '"01234"...')
+        else:
+          #libstdc++ string formatter suffers from the same problem as some_cstring below
+          pass
 
         some_carr = self.frame().FindVariable("some_carr")
         some_carr_summary = some_carr.GetSummary()


        


More information about the lldb-commits mailing list