[Lldb-commits] [lldb] [lldb] enhance colorize process for image lookup command (PR #76112)

[David Spickett via lldb-commits]

=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>,
=?utf-8?q?José?= L. Junior <jljuniorpb at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/76112 at github.com>


DavidSpickett wrote:

Drive by comments since I am low on time, also I will be away until early January from today.

A general comment, please keep each PR to one thing. So I'd say making the highlight stuff into a struct is one PR, then adding function highlighting is another. Makes it easier to understand for everyone involved.

On tests for function highlighting, assuming we know that `PutCStringHighlighted` works (which we do), we don't need to repeat single match, multiple match, end of string match, etc. for functions as well. Just check that the parts of the output for functions have some sort of highlight in them. Use the simplest query that will achieve that.

https://github.com/llvm/llvm-project/pull/76112