[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 19 04:53:11 PST 2023


DavidSpickett wrote:

`lldb/include/lldb/Symbol/CompileUnit.h`

```
  /// \param[in] lambda
  ///     The lambda that should be applied to every function. The lambda can
  ///     return true if the iteration should be aborted earlier.
  ///
  /// \return
  ///     If the lambda early-exited, this function returns true to
  ///     propagate the early exit.
  virtual bool ForEachExternalModule(
      llvm::DenseSet<lldb_private::SymbolFile *> &visited_symbol_files,
      llvm::function_ref<bool(Module &)> lambda);
```
I would have guessed true means continue.

Also, changing this didn't break any tests. So it would be nice to cover this but I don't know how. Would the whole test suite have to be built with modules enabled?

https://github.com/llvm/llvm-project/pull/75927


More information about the lldb-commits mailing list